Poor performance with utils.single_exchange.py._add_weighted_edge_to_graph()

wardbradt / peregrine

Detects arbitrage opportunities across 131 cryptocurrency exchanges in 50 countries

MIT License

1.19k stars 338 forks source link

Poor performance with utils.single_exchange.py._add_weighted_edge_to_graph() #22

Closed lnky79 closed 6 years ago

lnky79 commented 6 years ago

https://github.com/wardbradt/peregrine/blob/1bb84452f8788fb43426a3919693d2977da7df9a/peregrinearb/utils/single_exchange.py#L86

Hi, wardbradt. You sent multi http requests (by coroutine) refer to single symbol ( trade pair) with fetch_ticker(symbol=?) ，then fill with weighted edge. But fetch_tickers() contains all symbols` tick info at current time. Just one http request.

Maybe It will work.

lnky79 commented 6 years ago

My ccxt version is 1.12.111. After executing script，I got that： 69 exchanges does not support fetch_tickers () among with all 113 exchanges and the others are ok.

wardbradt commented 6 years ago

Pull request has been accepted; closing issue.