search

warden-protocol / wardenprotocol

Monorepo for the Warden Protocol.
https://wardenprotocol.org
Apache License 2.0
1.1k stars 112 forks source link

fix keys query #1016

Closed mn13 closed 2 weeks ago

mn13 commented 2 weeks ago

It contains two parts:

  1. Fix bug with AddressType conversion from evm to cosmos-sdk
  2. Change AddressesResponse in IWarden.sol from address to string

Summary by CodeRabbit

coderabbitai[bot] commented 2 weeks ago
📝 Walkthrough ## Walkthrough The changes in this pull request involve updates to the `CHANGELOG.md` and several files related to the `IWarden` contract, specifically addressing the conversion of address types. The `AddressesResponse` struct has been modified to change address representations from `address` to `string`. This affects ABI definitions and function signatures across multiple files, including `IWarden.go`, `IWarden.sol`, and `abi.json`. Additionally, the handling of derived addresses in request types has been updated, along with corresponding test case modifications. ## Changes | File | Change Summary | |----------------------------------------|----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------| | `CHANGELOG.md` | - Added bug fix entry for address type conversion in warden precompile.
- Updated bug fix entry for analyzers address conversion from `[]address` to `[]bytes`. | | `precompiles/warden/IWarden.go` | - Updated `AddressValue` field from `common.Address` to `string` in `AddressesResponse`.
- Modified ABI for functions `allKeys`, `keyById`, and `keysBySpaceId` to return `string` instead of `address`. | | `precompiles/warden/IWarden.sol` | - Changed `addressValue` field from `address` to `string` in `AddressesResponse`. | | `precompiles/warden/abi.json` | - Updated function outputs for `allKeys`, `keyById`, `keysBySpaceId`, and `keychains` to change `address` to `string` for `addressValue`. | | `precompiles/warden/query_types.go` | - Changed `DeriveAddresses` from `[]types.AddressType` to `[]int32` in `allKeysInput`, `keyByIdInput`, and `keysBySpaceIdInput`. | | `tests/cases/warden_precompile.go` | - Added debug logging in `Setup` method.
- Updated public key in `Run` method and modified handling of derived addresses.
- Adjusted expected response structure and assertions for key retrieval. | ## Possibly related PRs - **#984**: The main PR's changes regarding the address type conversion in the warden precompile directly relate to this PR, which also modifies the analyzers parameter type from `[]address` to `[]bytes` to accommodate larger CosmWasm contract addresses. ## Suggested labels `protocol`, `x-warden`, `go-client`, `test` ## Suggested reviewers - Pitasi - backsapc - artur-abliazimov

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.