Fix/expressions in precompile

[mn13]

Summary by CodeRabbit

• Bug Fixes

  • Resolved issues with address conversion in the warden precompile.
  • Ensured derived addresses are returned as strings.
  • Fixed errors related to empty keys in space.
  • Updated to return expressions in JSON encoding.

• Tests

  • Added comprehensive test scenarios for key management and space operations in the Warden protocol, including creation, fulfillment, and rejection of key requests.

[coderabbitai[bot]]

[!CAUTION]

Review failed

The pull request is closed.

📝 Walkthrough

## Walkthrough The pull request introduces several updates across multiple files, including the addition of new bug fix entries in the `CHANGELOG.md`, enhancements to JSON handling in `precompiles/act/types.go`, refinements in error handling in `precompiles/warden/query_types.go`, and the introduction of a new test case in `tests/cases/warden_precompile.go`. The changes focus on improving data representation, error checking, and expanding test coverage for key management functionalities. ## Changes | File | Change Summary | |-------------------------------------------|--------------------------------------------------------------------------------------------------------| | `CHANGELOG.md` | Added new entries under "Unreleased changes" for bug fixes related to address conversion and JSON encoding. | | `precompiles/act/types.go` | Modified `mapAction` function to marshal `ApproveExpression` and `RejectExpression` into JSON strings. | | `precompiles/warden/query_types.go` | Simplified nil-checking logic in `FromResponse` methods and updated handling of `Owner` field in `newSpacesByOwnerRequest`. | | `tests/cases/warden_precompile.go` | Added new test case "work with keys" to enhance testing of key management and space operations. | ## Possibly related PRs - **#433**: This PR adds tests related to keychain writers, which may indirectly relate to the changes in the main PR that involve address handling and conversions. - **#984**: This PR directly addresses the change of analyzers' types from `[]address` to `[]bytes`, which is a specific bug fix mentioned in the main PR's changelog. ## Suggested labels `protocol`, `test`, `wardenkms`, `protobuf` ## Suggested reviewers - backsapc - artur-abliazimov

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

🪧 Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

[github-actions[bot]]

Hey @mn13 and thank you for opening this pull request! 👋🏼

It looks like you forgot to add a changelog entry for your changes. Make sure to add a changelog entry in the 'CHANGELOG.md' file.

[vercel[bot]]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment

| Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **warden-help-center** | ⬜️ Ignored ([Inspect](https://vercel.com/qrdo-foundation/warden-help-center/9FwnfmpsKqp5feeoRQAQAjYzFotr)) | | | Nov 5, 2024 3:02pm |