search

warden-protocol / wardenprotocol

Monorepo for the Warden Protocol.
https://wardenprotocol.org
Apache License 2.0
1.1k stars 112 forks source link

feat(spaceward): decouple walletconnect storage #1074

Closed alex-nax closed 1 week ago

alex-nax commented 1 week ago

custom kvStorage for web3wallet; add suggestion to go to chainlink to select chain

Summary by CodeRabbit

Release Notes

These changes aim to improve user experience and system flexibility.

coderabbitai[bot] commented 1 week ago
📝 Walkthrough ## Walkthrough The pull request introduces several changes across multiple files in the project. It adds a new dependency, `"unstorage": "1.12.0"`, to the `package.json` file. Modifications are made to wallet integration in `App.tsx`, where wallet configurations are simplified. Environment variable management is enhanced in `env.ts`, and several components are updated to utilize a dynamic WebSocket URL for wallet connections instead of hardcoded values. Additionally, a new `custom-kv-storage.ts` file implements a key-value storage solution using IndexedDB, improving data handling capabilities. ## Changes | File Path | Change Summary | |---------------------------------------------|----------------------------------------------------------------------------------------------------| | `spaceward/package.json` | Added new dependency `"unstorage": "1.12.0"` in `dependencies` section. | | `spaceward/src/App.tsx` | Introduced `injectedWallet` and `walletConnectWallet` constants for wallet configuration. | | `spaceward/src/env.ts` | Added `wcWalletRelayUrl` constant from environment variable; updated `networkVisibility` type. | | `spaceward/src/features/actions/StatusSidebar.tsx` | Updated WebSocket URL to use `env.wcWalletRelayUrl`; refined action status handling. | | `spaceward/src/features/modals/ApproveActionModal.tsx` | Replaced hardcoded WebSocket URL with `env.wcWalletRelayUrl`. | | `spaceward/src/features/modals/ConnectedModal.tsx` | Updated WebSocket URL to use `env.wcWalletRelayUrl`. | | `spaceward/src/features/modals/WalletConnect.tsx` | Replaced hardcoded WebSocket URL with `env.wcWalletRelayUrl`; added import for `env`. | | `spaceward/src/features/walletconnect/WalletConnect.tsx` | Updated WebSocket URL to use `env.wcWalletRelayUrl`; added import for `env`. | | `spaceward/src/hooks/useWeb3Wallet.ts` | Added import for `IndexedDb` as `Storage`; updated `Core` instance initialization with storage. | | `spaceward/src/utils/contract.tsx` | Enhanced error handling in `assertChain` and `handleContractWrite` functions. | | `spaceward/src/utils/custom-kv-storage.ts` | Introduced new file implementing IndexedDB storage; defined `IndexedDb` class and related methods. | ## Sequence Diagram(s) ```mermaid sequenceDiagram participant User participant App participant WalletConnect participant StatusSidebar participant env User->>App: Initiate Wallet Connection App->>WalletConnect: Use env.wcWalletRelayUrl WalletConnect->>env: Fetch WebSocket URL env-->>WalletConnect: Return WebSocket URL WalletConnect->>User: Connect to Wallet User->>StatusSidebar: Check Connection Status StatusSidebar->>WalletConnect: Query for Status WalletConnect-->>StatusSidebar: Return Status StatusSidebar->>User: Display Connection Status ``` ## Possibly related PRs - **#385**: Related to changes in `package.json` that removes an existing dependency. - **#407**: Involves updates to `package.json`, focusing on new dependencies. - **#463**: Modifications to `package.json` that align with dependency updates. - **#517**: Addition of a new dependency relevant to wallet connection logic. - **#530**: Updates to wallet connection components related to dependency changes. - **#541**: UI fixes related to wallet connections that connect to `package.json` updates. - **#584**: Introduces new components related to key management, relevant to dependency changes. - **#601**: Addresses issues related to keys and spaces connected to `package.json`. - **#625**: Fixes related to wallet connections, relevant to changes in `package.json`. - **#676**: Addresses display issues related to actions, connected to `package.json` updates. - **#688**: Focuses on transaction status handling, relevant to new dependency addition. - **#699**: Reintroduces a MetaMask button for keys, related to `package.json` changes. - **#721**: Reverts updates in the environment configuration, relevant to dependency changes. - **#728**: Implements key creation in the sidebar, related to new dependency addition. - **#868**: Addresses technical debt related to `package.json` updates. - **#892**: Fixes issues related to sending Cosmos transactions, relevant to `package.json`. - **#1053**: Fixes faucet address format, connected to `package.json` changes. - **#1068**: Reduces calls to the EVM endpoint, relevant to `package.json` updates. ## Suggested labels `spaceward` ## Suggested reviewers - jjheywood

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### Documentation and Community - Visit our [Documentation](https://docs.coderabbit.ai) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
github-actions[bot] commented 1 week ago

Hey @alex-nax and thank you for opening this pull request! 👋🏼

It looks like you forgot to add a changelog entry for your changes. Make sure to add a changelog entry in the 'CHANGELOG.md' file.