warden-protocol / wardenprotocol

Monorepo for the Warden Protocol.
https://wardenprotocol.org
Apache License 2.0
1.1k stars 112 forks source link

1071 add aws kms to scheduler #1085

Open Svetomech opened 4 days ago

Svetomech commented 4 days ago

Summary by CodeRabbit

coderabbitai[bot] commented 4 days ago
📝 Walkthrough ## Walkthrough The pull request introduces significant updates to the `warden-automated-orders` project, primarily adding a new package for AWS KMS signing functionality. Modifications include new scripts in the `package.json` files, the addition of a new `AwsKmsSigner` class, and the incorporation of AWS KMS configuration into existing interfaces. The changes also enhance the build process and update environment variable requirements, reflecting a shift towards using AWS KMS for transaction signing. ## Changes | File Path | Change Summary | |---------------------------------------------------------------------------|---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------| | `automated-orders/package.json` | - Added script `"build:aws-kms-signer"`
- Updated script `"build:libs"` to include the new build script
- Added `"packageManager"` field specifying Yarn version | | `automated-orders/packages/aws-kms-signer/package.json` | - Introduced new package with metadata, marked as private
- Added scripts for `build` and `dev`
- Listed development and runtime dependencies | | `automated-orders/packages/aws-kms-signer/src/index.ts` | - Added `AwsKmsSigner` class with methods for signing transactions and retrieving addresses
- Introduced private methods for public key handling | | `automated-orders/packages/aws-kms-signer/src/types/configuration.ts` | - Added `IAwsKmsConfiguration` interface for AWS KMS settings | | `automated-orders/packages/aws-kms-signer/tsconfig.json` | - Added TypeScript configuration file with specific compiler options and directory settings | | `automated-orders/packages/blockchain-library/package.json` | - Added new dependencies: `@lapo/asn1js`, `@noble/secp256k1`, and `secp256k1` | | `automated-orders/packages/blockchain-library/src/clients/evm.ts` | - Integrated `AwsKmsSigner` into `EvmClient`, replacing private key handling
- Updated `sendTransaction` method to utilize the new signing mechanism | | `automated-orders/packages/blockchain-library/src/types/evm/configuration.ts` | - Updated `IEvmConfiguration` interface by removing `callerPrivateKey`, modifying `eventsCacheSize`, and adding `awsKmsSignerConfig` | | `automated-orders/packages/scheduler/src/config/config.ts` | - Updated JSON schema for environment variables: removed `EVMOS_CALLER_PRIVATE_KEY`, added `AWS_KMS_KEY_ID` and `AWS_KMS_REGION` | | `automated-orders/packages/scheduler/src/config/env.ts` | - Updated `Env` interface: removed `EVMOS_CALLER_PRIVATE_KEY`, added `AWS_KMS_KEY_ID` and `AWS_KMS_REGION` | | `automated-orders/packages/scheduler/src/index.ts` | - Replaced `callerPrivateKey` with `awsKmsSignerConfig` in the `main` function, ensuring initialization of the `evmos` client | | `automated-orders/tsconfig.json` | - Added reference to `aws-kms-signer` package | ## Possibly related PRs - **#840**: Changes involve removal of `template_id` fields, potentially impacting transaction handling. - **#868**: Focus on technical debt which may relate to code improvements connected to AWS KMS integration. - **#921**: Update to `wardenjs` package.json which could affect build processes. - **#1029**: Introduces worker setup in automated orders, related to build scripts in the main PR. - **#1039**: Addition of a blockchain layer aligns with AWS KMS signer integration. - **#1068**: Changes to reduce EVM endpoint calls could relate to efficiency improvements in the main PR. - **#1069**: Modifications to the scheduler are directly relevant to the main PR's enhancements. - **#1074**: Introduction of custom storage for wallet connections may relate to overall architecture improvements. - **#1078**: Transition to `viem` and `wagmi` for blockchain interactions is relevant to the new functionalities in the main PR. ## Suggested labels `automated-uniswap`, `wardenjs` ## Suggested reviewers - artur-abliazimov - mn13 - backsapc

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### Documentation and Community - Visit our [Documentation](https://docs.coderabbit.ai) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
vercel[bot] commented 3 days ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **warden-help-center** | ⬜️ Ignored ([Inspect](https://vercel.com/qrdo-foundation/warden-help-center/GThDWg3zoqghwTgEdyu5FRbivNSz)) | [Visit Preview](https://warden-help-center-git-1071-basicworker-aws-kms-qrdo-foundation.vercel.app) | | Nov 22, 2024 7:28am |
github-actions[bot] commented 2 days ago

Hey @Svetomech and thank you for opening this pull request! 👋🏼

It looks like you forgot to add a changelog entry for your changes. Make sure to add a changelog entry in the 'CHANGELOG.md' file.