Fix/eip1559 tx fields

[mn13]

Summary by CodeRabbit

• New Features

  • Introduced a new library for RLP encoding, enhancing transaction data handling.
  • Updated the BasicOrder contract to utilize RLP encoding for improved transaction compatibility.

• Bug Fixes

  • Improved address initialization in tests for better clarity and correctness.

• Chores

  • Removed the UnsignedEthTx struct to simplify transaction data handling in the codebase.

[coderabbitai[bot]]

📝 Walkthrough

## Walkthrough This pull request introduces a new Solidity library for RLP encoding, adds functionality to the `BasicOrder` contract to utilize this library for transaction encoding, and removes an unused struct from the `Types` library. The `BasicOrder` contract's `execute` function is modified to streamline parameters and enhance transaction handling. Additionally, updates are made to the testing setup for `BasicOrder`, improving clarity and structure without introducing new functionalities. ## Changes | File | Change Summary | |----------------------------------------|-----------------------------------------------------------------------------------------------------| | solidity/orders/src/BasicOrder.sol | - Added import for `RLPEncode`.
- Modified `execute` function: removed `gasPrice`, added unnamed parameter, and updated transaction encoding using RLP. | | solidity/orders/src/RLPEncode.sol | - Added new library `RLPEncode` with various encoding functions for bytes, strings, addresses, and integers. | | solidity/orders/src/Types.sol | - Removed `UnsignedEthTx` struct. | | solidity/orders/test/BasicOrder.t.sol | - Updated address initialization for clarity.
- Refined `beforeTestSetup` and `setUp` functions for better structure. | ## Possibly related PRs - #1080: The `BasicOrder` contract in this PR has been modified to include a new import for `RLPEncode`, which is directly related to the changes in the main PR that introduced the `RLPEncode.sol` file for RLP encoding functionalities. ## Suggested reviewers - backsapc - Svetomech

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

🪧 Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### Documentation and Community - Visit our [Documentation](https://docs.coderabbit.ai) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

[vercel[bot]]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment

| Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **warden-help-center** | ⬜️ Ignored ([Inspect](https://vercel.com/qrdo-foundation/warden-help-center/Dn7tj2B75182RMn8wovNgRszjcoW)) | [Visit Preview](https://warden-help-center-git-fix-eip1559-tx-fields-qrdo-foundation.vercel.app) | | Nov 22, 2024 1:42pm |