Closed Pitasi closed 1 week ago
[!WARNING]
Rate limit exceeded
@Pitasi has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 1 minutes and 29 seconds before requesting another review.
How to resolve this issue?
After the wait time has elapsed, a review can be triggered using the `@coderabbitai review` command as a PR comment. Alternatively, push new commits to this PR. We recommend that you space out your commits to avoid hitting the rate limit.How do rate limits work?
CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our [FAQ](https://coderabbit.ai/docs/faq) for further information.Commits
Files that changed from the base of the PR and between 82bf66b37c649a8f267138644017a63b575b7138 and e2cc3f1c660b7d3cfbce1e8dd30dbb7c48d22c24.
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Hey @Pitasi and thank you for opening this pull request! 👋🏼
It looks like you forgot to add a changelog entry for your changes. Make sure to add a changelog entry in the 'CHANGELOG.md' file.
I fixed the conflicts, could you reapprove @artur-abliazimov?
closes #255
I chose to use ECIES from the go-ethereum package: https://pkg.go.dev/github.com/ethereum/go-ethereum/crypto/ecies#section-readme which seemed an easy way of supporting at least one type of encryption. Maybe in the future we could support multiple schemes.
I added the encryption logic directly to the keychain-sdk so that multiple keychains implemented using it would benefit from this without having to change their internal logic.
The EncryptionKey field is completely optional, hence, this should be a non breaking change.