search

warden-protocol / wardenprotocol

Monorepo for the Warden Protocol.
https://wardenprotocol.org
Apache License 2.0
1.09k stars 96 forks source link

Qa issues #427

Closed alex-nax closed 6 days ago

alex-nax commented 1 week ago

Summary by CodeRabbit

github-actions[bot] commented 1 week ago

Hey @alex-nax and thank you for opening this pull request! 👋🏼

It looks like you forgot to add a changelog entry for your changes. Make sure to add a changelog entry in the 'CHANGELOG.md' file.

coderabbitai[bot] commented 1 week ago
Walkthrough ## Walkthrough The recent changes span various files, focusing on improving the rendering and styling of voting components, enhancing governance functionalities, refining input handling in staking features, and augmenting overall code efficiency. Key updates include styling adjustments, dynamic text rendering, new utility functions, and optimized calculations in state updates and transaction logic. ## Changes | File | Change Summary | |-----------------------------------------------------------|-----------------------------------------------------------------------------------------------------------------------------------| | `spaceward/src/assets/main.css` | Hide webkit scrollbar by setting its display property to none. | | `spaceward/src/features/governance/Chart.tsx` | Refactored styling logic for rendering vote percentage bars and updated calculation of segment percentages in a pie chart. | | `spaceward/src/features/governance/Item.tsx` | Introduced a new `voteAmounts` property to `ItemProps` and conditional state updates based on `voteAmounts`. | | `spaceward/src/features/governance/VoteModal.tsx` | Updated text to dynamically include proposal ID, name, and description within the `VoteModal` component. | | `spaceward/src/features/governance/VotesListModal.tsx` | Modified the CSS class for a `div` element to use `overflow-y-scroll` instead of `overflow-scroll`. | | `spaceward/src/features/governance/hooks.ts` | Removed a placeholder array of proposals and updated logic within `useGovernance` and `useGovernanceTx`. | | `spaceward/src/features/governance/types.ts` | Added a new field `voteAmounts` to the `GovernanceState` interface. | | `spaceward/src/features/governance/util.ts` | Added functions `biMinNoZero`, `divideWithDecimals`, and `bigintDiv`, and updated `formatResult` calculations. | | `spaceward/src/features/intents/Intent.tsx` | Removed a `console.log` statement related to the `intent` object. | | `spaceward/src/features/staking/RedelegateModal.tsx` | Imported `numRestrict` and replaced `strToBigint`, updating the `onChange` handler for the `address` input. | | `spaceward/src/features/staking/StakeModal.tsx` | Enhanced input handling with `numRestrict`, `maxAmount`, and error display logic, along with UI updates for errors. | | `spaceward/src/features/staking/util.ts` | Added `numRestrict` and `strToBigint` functions for number restriction and string to bigint conversion. | | `spaceward/src/pages/Governance.tsx` | Added `voteAmounts` in state, adjusted sorting logic based on `voteAmounts`, and updated the UI for proposal status filtering. | | `spaceward/src/pages/Intents.tsx` | Modified the `definition` assignment logic and reformatted parameter passing in `newAction`. | | `spaceward/src/pages/Staking.tsx` | Updated sorting logic to consider `sortKey` and `sortDirection` for organizing validators by various criteria. |

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.