search

warden-stack / Warden

Define "health checks" for your applications, resources and infrastructure. Keep your Warden on the watch.
https://getwarden.net
MIT License
615 stars 66 forks source link

Upgraded to target netcoreapp1.0 #106

Closed nimatt closed 8 years ago

nimatt commented 8 years ago

Since the rtm release of .Net Core 1.0 it is rather hard to get a machine to run RC1 which is needed in order for the Web Panel to work. I therefore changed it so it targets .Net Core 1.0 and .Net 4.6.1.

This is done rather quick (and a bit dirty) since I really needed it up and running. So there might be issues even if it seems to be working.

Let me know what is horrific and I'll go back and improve upon it :)

spetz commented 8 years ago

Thanks, I will take a look at this today once I get back home and will let you know.

spetz commented 8 years ago

At first glance everything seems to be working just fine. I'll need one or two more days to do more testing, find out if there are any packages that could be updated etc. and then I'll be able to merge this PR and publish new packages :).

spetz commented 8 years ago

Completed as manual merge (had to resolve some merge conflicts with the latest changes),

nimatt commented 8 years ago

Manual merge? If there where conflicts you had several good options such as

But it looks like you've created a new commit with the same changes. This makes it annoying for me since I'll will have to throw away my commit in my repo as well or handle the large number of conflicts this will result in. Also now you'll be author of those parts (sure it doesn't matter much with this example since it's not exactly amazing code) which is not really cool.

No big deal in this case but thought I'll let you know since it's rather off-putting for a contributer. Seems like a nice tool and I'll like it to prosper (so I can get more use out of it ;)

spetz commented 8 years ago

Apologies, I've had some issues related to one of the latest extensions on a separate branch and also had to update all of the packages versions accordingly. Maybe let's try to resolve this e.g. I could revert my changes, reset to the previous commit so that you would be able to push a commit based on the latest changes from the manual merge? I'm totally new to running the OS project, therefore I might make such mistakes ;).

nimatt commented 8 years ago

No worries, if we would fix it we probably would end up messing up more peoples repos though since we would be rewriting history and if they already pulled the commits it would end up being a bit of a mess. So I think we'll better leave it as is.

Feel free to ask me if you run in to similar situations again (with mine or other peoples code) and hopefully I'll be able to help, or make is worse ;)

spetz commented 8 years ago

Ok, thanks for the help and apologies one more time. I will contact you if I run into similar situations again and hopefully, we won't make things worse ;).

spetz commented 8 years ago

Just a short info about the update and the contribution.