search

warden-stack / Warden

Define "health checks" for your applications, resources and infrastructure. Keep your Warden on the watch.
https://getwarden.net
MIT License
615 stars 66 forks source link

Bug with Aggregate OnFailure Hooks #145

Open eoincampbell opened 7 years ago

eoincampbell commented 7 years ago

There's an issue in both the async & non-async aggregate hooks which results in the hook sending back the valid rather then invalid links.

See: https://github.com/warden-stack/Warden/blob/master/src/Warden/Core/IIterationProcessor.cs#L251

I'll submit a PR for this shortly.

spetz commented 7 years ago

Thanks, waiting for the PR then :).

eoincampbell commented 7 years ago

Hey @spetz have a couple of PRs coming.

  1. Fix for this issue
  2. New Integration for SMTP emails
  3. A new version of an IIteratorProcessor that deals with the other bug

One thing I've struggled to get working is the tests. Running dotnet test in the test project directory complains that there's no test adapter.

Do I need to get some external adapter for the Machine.Specification tests?