search

wardi / django-filebrowser-no-grappelli

django-filebrowser for default Django admin site. Based on https://github.com/sehmaschine/django-filebrowser v3.1 (before it was in git) Consider using https://github.com/smacker/django-filebrowser-no-grappelli which is based on a newer version
Other
149 stars 114 forks source link

CollapsedFieldsets.js is missing. #11

Open aronchi opened 14 years ago

aronchi commented 14 years ago

Upload form refers to this file, but it's missing:

I found it in grappelli, I think we should copy it into django-filebrowser-no-grappelli media files.

wardi commented 14 years ago

I'm hesitant to add anything from grappelli to -no-grappelli. If it works without the js then we should just remove the link.

aronchi commented 14 years ago

It's a useful js, because the popup dimension is fixed and the save button comes easily under the scroll, and it doesn't hurt.

I think you should add it, if you see its code you'll notice it's not a problem...

wardi commented 14 years ago

The file is in a grappelli branch but not in trunk, and it looks like code that should be part of the normal django admin, no?

aronchi commented 14 years ago

I didn't find that in django admin 1.2.1

wardi commented 14 years ago

ok, I'll take a patch that adds that one file

italomaia commented 14 years ago

collapse.js from django-admin seems to do something similar. Has anyone tried a fix with it?

wardi commented 14 years ago

yes, that's what I was looking for. A fix linking to collapse.js would be even better.