search

wardi / django-filebrowser-no-grappelli

django-filebrowser for default Django admin site. Based on https://github.com/sehmaschine/django-filebrowser v3.1 (before it was in git) Consider using https://github.com/smacker/django-filebrowser-no-grappelli which is based on a newer version
Other
149 stars 114 forks source link

FileBrowser styling issue #2

Closed trent closed 14 years ago

trent commented 14 years ago

I am seeing a styling issue on the FileBrowser listing page. See a screenshot here: http://img.skitch.com/20100122-gpd7a3b3fxe7jhfqt3usp6d9eh.jpg. As you can see in the red box I overlaid on the right, the search input field is extending beyond the browser window frame and the filter options are colored differently. I am using the latest version of django-filebrowser-no-grappelli with no modifications.

I also have a screenshot of an older version of FileBrowser from the original repo here: http://img.skitch.com/20100122-kb7e219kucbsjjkfnpeug1cmu9.jpghttp://img.skitch.com/20100122-kb7e219kucbsjjkfnpeug1cmu9.jpg. This version shows how I'd expect to see the listing page.

Is this a known bug?

wardi commented 14 years ago

looks like someone has already fixed this: http://github.com/jbeaurain/django-filebrowser-no-grappelli/commit/e6ab838eee818efde86089a757394e101934dd6e

does that fix work for you?

trent commented 14 years ago

Here is a screen shot of my admin with this fix: http://img.skitch.com/20100124-pgd3gi6m96exn4w15xtqxfawn7.jpg

This works in so much as the search box no longer extends beyond the browser window. But the styling is still not as I would expect it.

But, yes, it is better and satisfies the reported styling issue.

wardi commented 14 years ago

applied jbeaurain's fix