search

wardi / django-filebrowser-no-grappelli

django-filebrowser for default Django admin site. Based on https://github.com/sehmaschine/django-filebrowser v3.1 (before it was in git) Consider using https://github.com/smacker/django-filebrowser-no-grappelli which is based on a newer version
Other
150 stars 114 forks source link

Conditionally imports native json vs simplejson based on python version #61

Closed RandomJo closed 9 years ago

RandomJo commented 9 years ago

This only needed a simple fix to make it compatible with up to Django 1.8. By conditionally importing native json versus simplejson from django.contribs, this can work with all up to date versions of Django.

jose-lpa commented 9 years ago

Hi there, thanks for the contribution :)

It looks like the latest person who contributed to this repo was me in late 2013... and now somehow I am even able to merge others pull requests.

If this repo is useful for you @RandomJo , I will merge it. However, if you are using this code in your projects, you may want to use the smacker's fork, which is up-to-date and have proper unit testing and docs, instead of continue using this repo, which is pretty much abandoned. Maybe next time you'll want to contribute to that repo also, because the whole development is done there.

Just to let you know!

RandomJo commented 9 years ago

Thanks. I’d like to migrate to the maintained fork, but I was running into issues with it. I’m assuming that’s because it doesn’t yet support Django 1.8. This was a simple fix for my client, so I went with it.

On Wed, Jul 1, 2015 at 12:53 PM, José L. Patiño Andrés notifications@github.com wrote:

Merged #61.

Reply to this email directly or view it on GitHub: https://github.com/wardi/django-filebrowser-no-grappelli/pull/61#event-345674590