search

wardi / jsonlines

Documentation for the JSON Lines text file format
http://jsonlines.org
139 stars 34 forks source link

Examples are very hard to read #51

Closed sigzero closed 1 year ago

sigzero commented 3 years ago

The examples have red on black. Very hard to read. Either just use HTML formatting or change the theme for the pictures. Please.

hashbackup commented 2 years ago

The whole site is hard to read, especially for people with eyes older than 20. I know that designers think low-contrast text is somehow a good thing and aesthetically pleasing, but from a practical point of view, they're wrong.

wardi commented 2 years ago

I agree. PRs welcome.

sp4ce commented 1 year ago

@wardi the change seems simple enough, and looking at the screenshot, it looks good to me. I am inclined to merge it, sounds good?

btw, I also created https://github.com/wardi/jsonlines/issues/67 because I think you do the deployment manually (I think you mentioned that to me at some point), so I am not sure if just merging the changes would have any impact if you don't deploy after.

wardi commented 1 year ago

@sp4ce go for it. The site is html at the moment so there is no deployment process other than pushing changes.