search

wardz / ClassicCastbars

[WoW] Customizable target castbars for Classic and Retail.
63 stars 5 forks source link

Castbar Player doesn't render properly after a reload UI, with the option "Cast Bar Underneath" #21

Closed CaffeinatedCake closed 5 years ago

CaffeinatedCake commented 5 years ago

Bug reproduced in v1.1.1 and v1.1.2

What is the problem? Is there any Lua errors? The option "Cast Bar Underneath" doesn't work properly after a reload UI. The cast bar stops being properly rendered in the interface. There's no Lua error.

What steps will reproduce the problem? After activating the castbar for the player, which works perfectly fine, I activate the option "Cast Bar Underneath": WoWScrnShot_102319_211440

Once it's done, it's working fine: WoWScrnShot_102319_211457

But if you restart the game, or even simply do a reload UI, this is what you end up with: WoWScrnShot_102319_211526

At that point, it even shows on the "Toggle Testing Player" bar: WoWScrnShot_102319_211552

If I just disable the option "Cast Bar Underneath" after that, this is what I get: WoWScrnShot_102319_211610

Once the option is disabled and the interface reloaded, I'm back to normal: WoWScrnShot_102319_211624

Does the issue still occur when all addons except ClassicCastbars are disabled? Yes, it does.

Was it working in a previous version? If yes, which was the last good one? I started using ClassicCastbars from the v1.1.1, and the bug already existed at that point. I don't know about older versions.

wardz commented 5 years ago

Thanks for reporting, fixed it now. Will upload the new version tomorrow most likely.

PS: You'll have to manually change the castbar size when enabling castbar undearneath option if you want it small, since the persistent addon config is default set to same size when using non underneath bar.

CaffeinatedCake commented 5 years ago

Great news! And I don't mind the extra step to get it to the right size. The config is pretty easy anyway, this is why I like this addon.

I will most likely test that this evening, after work.

CaffeinatedCake commented 5 years ago

Alright, I just did my test (I took the file you modified and use it in the current version, because I'm patient like that). It's all good!

Side note, the size options don't seem to want to use the round values I type :') (but I don't really care, 0.1 is not something I'll catch by eyes on my castbar) Capture

A quick suggestion for a possible future version would be to add a reset button for the castbars dimensions, so people don't complain about not remembering the default values.

Anyway, thanks for the fix and your work on this addon! Have a great day!/night!