search

wardz / DRList-1.0

[WoW] Library for providing player diminishing returns categorization.
16 stars 10 forks source link

[BUG]: Wrong DRs TBC #5

Closed XiconQoo closed 2 years ago

XiconQoo commented 2 years ago

What happened?

Yo @wardz, I am the author of Gladdy.

I recently tested DRs extensively on PTR. My self-maintained DR-lib is quite accurate now. You might want to take a look and find diffs

-> https://github.com/XiconQoo/Gladdy-TBC/blob/main/Libs/DRData-1.0/DRData-1.0.lua

Is there any errors?

No response

Game Version

The Burning Crusade Classic

Game Language

English, French, German, Italian, Korean, Chinese, Russian, Spanish, Brazil

Any additional info?

No response

wardz commented 2 years ago

Hey, thanks a lot, will look into it asap! I prob won't be playing classic again untill Wotlk gets released so this is extremely helpful :partying_face:

wardz commented 2 years ago

Just to confirm, does disarms and Improved Wing Clip not have any DRs in TBC?

XiconQoo commented 2 years ago

Actually I did not test disarm. Since warrior (to my knowledge) is the only class in TBC to be able to disarm, I neglected it. For completeness you can add it, as it definetely has a DR. I might add it as well, since I track Death Coil as well.

Imp Wingclip should be added as well, thanks (rndroot). Entrapment is missing to (hunter talent rndroot on traps)

vendethiel commented 2 years ago

As a user of drtracker (for gladiusex), this being updated would be nice :)

wardz commented 2 years ago

Added now in v1.2.8. Thanks again.

Since warrior (to my knowledge) is the only class in TBC to be able to disarm, I neglected it. For completeness you can add it, as it definetely has a DR.

Rogues got disarm aswell with Riposte talent. But yeah in arena you wont really see this DR 99% of the time, it's more for BGs/world pvp.