warelab / sciapps

SciApps: a cloud-based platform for reproducible bioinformatics workflows
https://www.sciapps.org
Apache License 2.0
2 stars 1 forks source link

DE's fix on Aloe #99

Closed liyawang closed 5 years ago

liyawang commented 5 years ago

Hi Liya,

Sure. The changes were pretty simple. Here’s what I did:

Removed the unsupported appName and appDescription fields that the DE had been sending. Added support for the new ACCEPTED and BLOCKED job statuses (this only applies to the handling of job status updates in the DE.

Here are the app IDs that I used for testing:

Interproscan–5.33.72u1 racon-s2–1.3.2u1

I chose racon because it has some parameters of different types (numeric and Boolean, if I remember correctly), and I wanted to make sure that the DE was sending the correct JSON types in the request.

We did have to make a slight modification to the request JSON. The request that the DE had been formatting had two fields that were unsupported. I removed those fields from the request. The DE wasn’t extracting much from the response JSON, so it wasn’t necessary to change the way that the response was being processed.

Sarah

liyawang commented 5 years ago

Incorporated.