search

warengonzaga / gathertown.js

Simple and lightweight community contributed unofficial JS/TS SDK for Gather Town's HTTPS and WebSocket APIs. 🌏🕹💬
https://gathertown.js.org
MIT License
40 stars 6 forks source link

typescript support #22

Closed princejoogie closed 2 years ago

princejoogie commented 2 years ago

Any plans on converting to typescript? ill be willing to contribute.

Also can setup husky for #20 which can run test and linters before commit (pre-commit hooks) sample of the template is with a boilerplate i made node-app-bp which has husky and eslint configured and is using esbuild to compile

-> esbuild performance <- image

warengonzaga commented 2 years ago

Hi @princejoogie, I have plans in converting it to typescript which is better for maintaining the project. If you can do it feel free to submit a PR to the dev branch referencing this issue.

warengonzaga commented 2 years ago

Also, what do you think @jofftiquez regarding this?

jofftiquez commented 2 years ago

This is a great suggestion. I was also thinking of suggesting esbuild, but I can't recall the name yesterday xD. But yeah, esbuild is better.

warengonzaga commented 2 years ago

Let's implement esbuild, the same thing, I forgot the name of it lol.

warengonzaga commented 2 years ago

Closing this now, thanks to @princejoogie for the contribution!