search

warengonzaga / gathertown.js

Simple and lightweight community contributed unofficial JS/TS SDK for Gather Town's HTTPS and WebSocket APIs. 🌏🕹💬
https://gathertown.js.org
MIT License
40 stars 6 forks source link

concern on sqaushed commits #29

Closed princejoogie closed 2 years ago

princejoogie commented 2 years ago

@WarenGonzaga how will i create PR to dev branch if the dev branch here is squashed? image

opening a PR will include all my previous commit (unsquashed) image

pulling from your repo as upstream doest squash in my fork, how will i handle this

warengonzaga commented 2 years ago

Save your changes @princejoogie and delete your fork. Then re-fork it and apply your latest changes then you can PR safely. Squash means making your PR all in one. Meaning, your code is still updated but changed the commit message.