Closed princejoogie closed 2 years ago
I can send screenshots of my manual tests per route if needed š
I can send screenshots of my manual tests per route if needed š
I was thinking of jest for testing the API wrapper. We did a similar approach on BMC.JS but it is not successful. For the examples folder basically these are the manual tests?
I can send screenshots of my manual tests per route if needed š
I was thinking of jest for testing the API wrapper. We did a similar approach on BMC.JS but it is not successful. For the examples folder basically these are the manual tests?
yes it is sort of a manual test. was gonna ask in discussions if we were going to implement jest, but since you mentioned it, ill try to implement it when im free again
I can send screenshots of my manual tests per route if needed š
I was thinking of jest for testing the API wrapper. We did a similar approach on BMC.JS but it is not successful. For the examples folder basically these are the manual tests?
yes it is sort of a manual test. was gonna ask in discussions if we were going to implement jest, but since you mentioned it, ill try to implement it when im free again
I'll create an issue regarding automated testing with Jest. Also adding a discussion related to this.
Hi, @princejoogie did you change how we use the API? If yes, then how to use it? I'm concerned about documentation.
Hi, @princejoogie did you change how we use the API? If yes, then how to use it? I'm concerned about documentation.
the only change i made is mentioned in PR description number 1. from positional arguments to object arguments. yes, this change will need to be redocumented in usage.
Hi, @princejoogie did you change how we use the API? If yes, then how to use it? I'm concerned about documentation.
the only change i made is mentioned in PR description number 1. from positional arguments to object arguments. yes, this change will need to be redocumented in usage.
This is clear to me, basically, the usage now for the API wrapper is OOP?
@princejoogie did you rename the createRoom
to createSpace
?
@princejoogie did you rename the
createRoom
tocreateSpace
?
@princejoogie next time, use imperative sentences to your commit message. Use add
instead of added
as an example.
Finished all HTTP APIs for #11 and fixed bug of #31
NEW CHANGES
Positional arguments to Object arguments
Re-wrote
requester
and separated each API routeEXAMPLES
src/examples/index.ts
. this file can be executed directly without compiling withnpx ts-node src/examples/index.ts
API_KEY
variable should be changed accordingly as well asSPACE_ID_1
andSPACE_ID_2
SPACE_ID_2
is used insetMapSample
function.