search

wareya / nazeka

Nazeka is a rikai replacement
https://addons.mozilla.org/en-US/firefox/addon/nazeka/
50 stars 8 forks source link

"Popup requires key" setting sometimes gets ignored #10

Closed o0o0 closed 5 years ago

o0o0 commented 5 years ago

I have the popup key set to shift, but sometimes nazeka ignores this and behaves according to the default settings (no popup key). This seems to happen randomly, and refreshing the page always fixes the problem. When this bug does appear, it doesn't affect all of my open tabs, it only happens on an individual tab basis.

wareya commented 5 years ago

Interesting. Is keyboard focus on something else? Does it only happen on certain pages?

o0o0 commented 5 years ago

It can happen on any page. I think I managed to reproduce the behavior. Set the popup key to ctrl, bring up the definitions window and then use ctrl+tab or ctrl+number to switch tabs while the popup is still open. When you switch back to the original tab, the popups will continue to show up without using the ctrl key. The same thing happens when I set the popup key to shift and use shift+k in Vimium to switch tabs. However, it works properly if the two actions don't use the same modifier key.

wareya commented 5 years ago

I see, yeah, that prevents the keyup even from firing. I'll look into it.

wareya commented 5 years ago

I did something that I think should fix this. Feel free to post again if the next update doesn't fix this.