wareya / nazeka

Nazeka is a rikai replacement
https://addons.mozilla.org/en-US/firefox/addon/nazeka/
50 stars 8 forks source link

Disable text lookup while sticky search is enabled. #21

Closed epistularum closed 5 years ago

epistularum commented 5 years ago

Most of the time when I enable sticky search is too scroll through a definition but words get looked up when you're trying to reach the pop up window.

Note: Applying a pop up key obviously solves this.

wareya commented 5 years ago

I tend to use the mining UI for this even though I'm not actually mining.

epistularum commented 5 years ago

What about combining the mining UI with sticky mode since they offer a similar feature?

wareya commented 5 years ago

Mining UI needs to not change when mousing over stuff, since you can look stuff up in it as well.

epistularum commented 5 years ago

Users should be allowed to search within the sticky mode as well, don't you think?

wareya commented 5 years ago

Sticky mode is supposed to update when the mouse scans over different text, so...

epistularum commented 5 years ago

For j-j dictionaries it might be useful to look-up unknown words directly in the sticky window.

I feel like using the mining UI to scroll through definitions when not using a keyboard shortcut for look-up is strange and not intuitive.

wareya commented 5 years ago

I can pretty easily make it so mousing over the sticky window doesn't do anything, but I have no easy way of letting you do lookups inside of the sticky window. What happens when you press the left/right arrow key? Does it seek left/right in the sticky window or the normal window?

epistularum commented 5 years ago

I'm having some issues interpreting what you just wrote. Are you saying that there are two windows opened at the same time?

wareya commented 5 years ago

Well, that's how looking stuff up in the mining UI works. If you were to look something up in the sticky window, then either you'd get a second definitions list (so you can look up multiple words in the same sentence), or it would replace the sticky window's contents entirely (making it so you could only look up a single thing, and now you have to look the original thing up again).

epistularum commented 5 years ago

Ok I understood.

We could combine the mining UI with sticky mode by keeping the sticky mode behavior where the main windows updates when we look up words on the page but looking up a word in the window itself pops up another window.

But then we still have the issue where the window is unreachable with automatic look up enabled.

wareya commented 5 years ago

That would be the first option, and I don't have an easy way of doing it because so many things (including keyboard controls) assume that there's exactly one real definitions popup.

Basically, there's a reason I silently decided that the mining UI is the intended place to look up Japanese stuff in definitions.

wareya commented 5 years ago

Closing this because it's too far detached from how nazeka handles the popup window internally.