wargio / r2dec-js

radare2 plugin - converts asm to pseudo-C code.
514 stars 50 forks source link

pdd* should just print the commands to run #142

Open radare opened 5 years ago

radare commented 5 years ago

The usage of the '*' suffix in r2 specifies that it will print the commands, not execute them. You can use a different modifier like pdd** to do this internally with the api if you want, but ideally the usage should be .pdd*

wargio commented 5 years ago

you told me to add pdd* as CCu base64:AAAA= :/ what should it output then?

radare commented 5 years ago

yes, but it should PRINT this stuff, not execute it

On 5 Mar 2019, at 17:40, Giovanni notifications@github.com wrote:

you told me to add pdd* as CCu base64:AAAA= :/ what should it output then?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/wargio/r2dec-js/issues/142#issuecomment-469753494, or mute the thread https://github.com/notifications/unsubscribe-auth/AA3-lr23cKZK4FsBjZRULvOeDD6WPn-Jks5vTp4bgaJpZM4bdb2M.

wargio commented 5 years ago

ohhhhhhhhhhhhhhhhhhh so it should print a big line with 'CCu base64:AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAaAA=' ??

Maijin commented 5 years ago

yes

Maijin commented 5 years ago

the user can apply them using .pdd*

radare commented 5 years ago

agree

On 3 Jun 2019, at 07:25, Maijin notifications@github.com wrote:

the user can apply them using .pdd*

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/wargio/r2dec-js/issues/142?email_source=notifications&email_token=AAG75FVLWPHRSFKHJWYMEHDPYT5RBA5CNFSM4G3VXWGKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWZDKKY#issuecomment-498218283, or mute the thread https://github.com/notifications/unsubscribe-auth/AAG75FT2V5V24YKCGSHTCPLPYT5RBANCNFSM4G3VXWGA.

trufae commented 3 days ago

another option is to spit out ano=base64:... which is a new command to support function anotations

trufae commented 3 days ago

that would be good to have before cutting 596