Tag a new release for 5.9 and fix readme

wargio / r2dec-js

radare2 plugin - converts asm to pseudo-C code.

508 stars 48 forks source link

Closed trufae closed 3 months ago

trufae commented 3 months ago

For packaging purposes we cant use the 5.8.8 release because it doesnr build with latest r2.

Also the readme build instructions are not correct anymore and should be updated.

thanks!

trufae commented 3 months ago

Also, the release tarball may include a copy of the qjs source, so it can be compiled offline

prodrigestivill commented 3 months ago

As a note, to pre-download the sources it can be done by running:

meson subprojects download

Later the user can use the following command to apply the changes overlay if required:

meson subprojects packagefiles --apply

wargio commented 3 months ago

Also the readme build instructions are not correct anymore and should be updated.

besides meson setup ... what else is not valid anymore?

prodrigestivill commented 3 months ago

what else is not valid anymore?

2 parts, the cd p and -Djsc_folder=".." param. since p no longer contains meson build.

wargio commented 3 months ago

what else is not valid anymore?

2 parts, the cd p and -Djsc_folder=".." param. since p no longer contains meson build.

that was the part i was referring to.

prodrigestivill commented 3 months ago

Was r2dec-js 5.9.0 planned to be released as part of this issue? Or when is expected to be released the next release?

Thanks in advance for the information.

wargio commented 3 months ago

sorry, i travelled in the past 2 days and i didn't have access to internet

wargio commented 3 months ago

trufae commented 3 months ago

No hurry at all. Good to see another release out!

prodrigestivill commented 3 months ago

Thanks @wargio, there were no rush at all but we appreciate a lot your dedication.

Regarding the new artifact generated "src-with-deps".

I would suggest if you can remove it manually when you have time and reupload after PR #309 or similar has been merged.