warm-metal / container-image-csi-driver

Kubernetes CSI driver for mounting image
MIT License
30 stars 22 forks source link

Update CI tests to have better logging #138

Closed mbtamuli closed 5 months ago

mbtamuli commented 9 months ago

The tests running as part of the CI don't provide any logs right now. Would be good to have the cluster logs as part of the CI run itself.

mbtamuli commented 9 months ago

An example I can show is - https://github.com/mbtamuli/csi-quickstart/actions/runs/7567889768. As part of the pipeline, regardless of tests passing or failing, I ensure the logs are uploaded as artifacts

image

You get a lot of information about the cluster itself

➜  container-image-csi-driver git:(devcontainer) ✗ tree -L 3 cluster-logs-csi-d431fc
cluster-logs-csi-d431fc
├── csi-d431fc-control-plane
│   ├── alternatives.log
│   ├── containerd.log
│   ├── containers
│   │   ├── coredns-5d78c9869d-lmcbs_kube-system_coredns-dd0b9125af2888cbeb89f9c521c271e85fb30b0df2b333d133b2d55c8263adef.log
│   │   ├── coredns-5d78c9869d-vdl2s_kube-system_coredns-b0f28b7b5a9554cde603a98e9b30c841b5edc7eb8aa0e77b79b2c18d43caf243.log
│   │   ├── emptydirclone-plugin-bbkr2_emptydirclone_csi-volume-driver-562ad8f2d614d32c1c43d9bf31f5ef001a83cc8ea5883ac6574d5a250b8b3b56.log
│   │   ├── emptydirclone-plugin-bbkr2_emptydirclone_node-driver-registrar-b81cef83d6670a4e86d61b7e172711e98019e3280c4c11a4642fdb4a4eab543f.log
│   │   ├── etcd-csi-d431fc-control-plane_kube-system_etcd-7175d7b50bfeaa330267b657612f75eaea949aecee1aadfb244f0ba3c28ce81f.log
│   │   ├── kindnet-jnkd9_kube-system_kindnet-cni-0f8113bcd2e187b574145b2ad5a952b085faff801b8960af1c33a1913b1869ef.log
│   │   ├── kube-apiserver-csi-d431fc-control-plane_kube-system_kube-apiserver-5335f3eb80566514a43a57f591e5d6b564e262cf3ab8e7d26f97f4dbbab987ba.log
│   │   ├── kube-controller-manager-csi-d431fc-control-plane_kube-system_kube-controller-manager-f4949ced780967762af5c730b3c58af90fb91c1accb1748030c28a4fb2815ead.log
│   │   ├── kube-proxy-w8vzb_kube-system_kube-proxy-03280d23c75a1524e402340d4b33a8cedd7e399fb6545bcf3e9dd04ed4872887.log
│   │   ├── kube-scheduler-csi-d431fc-control-plane_kube-system_kube-scheduler-fe36f2922f7493dffeb3987f3c17293964e6665b1fa0de53612e4c4f58367ae6.log
│   │   └── local-path-provisioner-6bc4bddd6b-976rc_local-path-storage_local-path-provisioner-8ddaeefd3578453ce71f27e1e1c0ab189cdec51ea24d89615a01dff445d8107a.log
│   ├── images.log
│   ├── inspect.json
│   ├── journal.log
│   ├── kubelet.log
│   ├── kubernetes-version.txt
│   ├── pods
│   │   ├── emptydirclone_emptydirclone-plugin-bbkr2_5b0272bc-2e63-4b73-8383-0b10eb028055
│   │   ├── kube-system_coredns-5d78c9869d-lmcbs_7dd604a3-50bf-4250-8c74-95561d523583
│   │   ├── kube-system_coredns-5d78c9869d-vdl2s_92bd7bee-39ac-4777-b56d-a9c5012b32d5
│   │   ├── kube-system_etcd-csi-d431fc-control-plane_30c519a7f885062f864cdf10c044b29e
│   │   ├── kube-system_kindnet-jnkd9_3807a425-cc9d-48fe-a218-47b3186f450a
│   │   ├── kube-system_kube-apiserver-csi-d431fc-control-plane_e23d73f220c6f9d5f1539a9a2b4529c3
│   │   ├── kube-system_kube-controller-manager-csi-d431fc-control-plane_18611c62ddab1fb2a8064a75b15e58d8
│   │   ├── kube-system_kube-proxy-w8vzb_95f7c36c-9156-416c-abdd-775cb12bdbf2
│   │   ├── kube-system_kube-scheduler-csi-d431fc-control-plane_faa0bf7c90a839e555cd821c6d9d061f
│   │   └── local-path-storage_local-path-provisioner-6bc4bddd6b-976rc_6b299adf-e96a-4fa4-a54f-48824eae9677
│   └── serial.log
├── docker-info.txt
└── kind-version.txt

14 directories, 21 files

Note: This is just an example. I'm using https://github.com/kubernetes-sigs/e2e-framework in my repository.

mbtamuli commented 9 months ago

Another new feature of GitHub that we could leverage is Job Summaries - https://github.blog/2022-05-09-supercharging-github-actions-with-job-summaries/

mbtamuli commented 9 months ago

I got this idea, after looking at the PR #137 and noticing the tests are failing, but the logs in the CI tests not being helpful.

mugdha-adhav commented 9 months ago

@mbtamuli would you like to work on this?

mbtamuli commented 9 months ago

I've got a lot on my plate, so I'll ask to be assigned to the issue once I get time. By then if someone else wants to work on this, that's fine with me.

github-actions[bot] commented 6 months ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs.

github-actions[bot] commented 5 months ago

Closing this issue after a prolonged period of inactivity. If this issue is still present in the latest release, please feel free to create a new issue with up-to-date information.