warmachine028 / uemcrp

A better clean and minimalist academic CRP built on MERN stack
https://uemcrp.netlify.app
MIT License
35 stars 38 forks source link

Removed name field from paper component #73

Closed GabrielWarner closed 2 years ago

GabrielWarner commented 2 years ago

Issue 📐

Guidelines 🔐

I accept the fact that i have followed the guidelines and have not copied the codes from around the internet

Issue to be closed 🛅

Screenshots 📷

Here are the pictures of changes that i have made 🔽

BEFORE ![image](https://user-images.githubusercontent.com/98490756/193744524-ec471a5a-d27c-41bb-8dac-723f3681af10.png) AFTER ![image](https://user-images.githubusercontent.com/98490756/193744550-d7a2317f-075d-43b0-b13f-d156b1ff4a03.png) ---
netlify[bot] commented 2 years ago

Deploy Preview for uemcrp ready!

Name Link
Latest commit f0674de468a2f0bfea26e6ba160353b5a8a46cf2
Latest deploy log https://app.netlify.com/sites/uemcrp/deploys/633bce0622d26a0009ede9f6
Deploy Preview https://deploy-preview-73--uemcrp.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

warmachine028 commented 2 years ago

Screenshot_2022-10-04-11-25-25-69_40deb401b9ffe8e1df2f1cc5ba480b12

GabrielWarner commented 2 years ago

Oh ok I will fix this

GabrielWarner commented 2 years ago

image On line 26 I'm now referencing the name using "user.name" instead of "data.name"

warmachine028 commented 2 years ago

Correct!. Now make sure if this PR is being shown in your hacktoberfest profile, so that I can add hacktoberfest-accepted tag

GabrielWarner commented 2 years ago

Is this what you are talking about? This is literally my first contribution to open source :) This is the PR that it is linkinng to

image

warmachine028 commented 2 years ago

Great! Accepting

Is this what you are talking about? This is literally my first contribution to open source :) This is the PR that it is linkinng to

image

Yes it is being shown, now after I accept the PR it would Waiting 7 Days.

Great Job ⭐ on your first contribution.