search

warmfusion / sensu-extension-snmptrap

An SNMP Trap extension for Sensu that runs inside the Sensu-Client waiting for SNMP events to come in
MIT License
7 stars 9 forks source link

Big Refactort to align with sensu plugin format #2

Closed warmfusion closed 8 years ago

warmfusion commented 9 years ago

References:

warmfusion commented 9 years ago

Hi @countryHick Would you be able to have a quick lookover these changes and sanity check them?

No real functionality changes - a curios typo around the snmp trap handling and refactors based on robucop but otherwise its a topological change and some(lots) of additional framework stuff to make the extension more portable

Cheers

ghost commented 9 years ago

First glance looks fine - will try and get my testing env back up and running and apply there to check.

ghost commented 9 years ago

@warmfusion - finally getting back to this - are you good to merge or have you transferred to the main plugins repos yet?

warmfusion commented 9 years ago

Happy to merge away - no one's suggested how to incorporate extensions into the sensu architecture, so might as well follow some conventions like this for now.