warmsound / crystal-face

Garmin Connect IQ watch face
https://apps.garmin.com/en-GB/apps/9fd04d09-8c80-4c81-9257-17cfa0f0081b
GNU General Public License v3.0
381 stars 124 forks source link

Modification by SG #184

Open SylvainGa opened 3 years ago

SylvainGa commented 3 years ago

Addition of French localization Addition of Pulse Ox as a data field Modification to the AlwaysOn to reduce batterie drain

warmsound commented 3 years ago

@SylvainGa thanks for all your hard work on this 🤝 . I'm starting the review, and will submit comments shortly.

SylvainGa commented 3 years ago

Do you have a vector version of the O2 icon? If so, I'd like to update the crystal-icons.afdesign Affinity Designer file after merge. If not, don't worry.

Thanks again for your work on this. If you'd like any help addressing the comments, please let me know.

No, I'm sorry. I don't have a vectored graphic for the O2. I simply used PaintShop Pro and used the font Segoe UI to write O and 2 using two different font size.

warmsound commented 3 years ago

@SylvainGa, would you like any help with this? I'd be happy to merge as is, and then I could make further changes before release, along the above lines. Your changes are valuable, so it'd be great to get them in đź‘Ť

SylvainGa commented 3 years ago

Sorry, had a ski accident. I went through what was posted and see what I can do this week,

warmsound commented 3 years ago

Sorry to hear about your accident. Wishing you a speedy recovery, and thank you again for your work on this - there's no urgent hurry.

lrosenman commented 3 years ago

I would love to see this make it into a release at some point.

SylvainGa commented 3 years ago

I've started working on it again. Refreshed my laptop so had to refork and redo my changes (kept my source). See my question in your post about Pulse Ox

https://github.com/warmsound/crystal-face/pull/184#discussion_r711116369

SylvainGa commented 2 years ago

Hi Larry, hope you're doing well. I haven't seen any movement for almost a year in your crystal-face Garmin watchface. Are you still planning on releasing a new version with the updated code?

Regards, Sylvain.

Le mer. 9 juin 2021, Ă  22 h 46, Larry Rosenman @.***> a Ă©crit :

I would love to see this make it into a release at some point.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/warmsound/crystal-face/pull/184#issuecomment-858237333, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALYXESRJVSDBYQAK5ZTW5LLTSARR7ANCNFSM4VQ2A26Q .

lrosenman commented 2 years ago

I'm not the code owner.

@warmsound is.

SylvainGa commented 2 years ago

Hi, I hope you're doing well. I haven't seen any movement for almost a year in your crystal-face Garmin watchface. Are you still planning on releasing a new version with the updated code?

Regards, Sylvain.

Le jeu. 28 janv. 2021, Ă  12 h 47, warmsound @.***> a Ă©crit :

Sorry to hear about your accident. Wishing you a speedy recovery, and thank you again for your work on this - there's no urgent hurry.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/warmsound/crystal-face/pull/184#issuecomment-769259794, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALYXEST5BGCL7EMAQHAXAGDS4GPKHANCNFSM4VQ2A26Q .

SylvainGa commented 2 years ago

Yeah, sorry. Replied to the wrong thread.

Le mar. 22 mars 2022, Ă  20 h 07, Larry Rosenman @.***> a Ă©crit :

I'm not the code owner.

@warmsound https://github.com/warmsound is.

— Reply to this email directly, view it on GitHub https://github.com/warmsound/crystal-face/pull/184#issuecomment-1075769942, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALYXESW23TW25DED4YHUYYDVBJOETANCNFSM4VQ2A26Q . You are receiving this because you were mentioned.Message ID: @.***>