SylvainGa
commented
1 year ago Hi, I haven't had the time to look at it yet but should be able before the end of the week.
Le lun. 18 sept. 2023, à 17 h 46, Adrien Chenu @.***> a écrit :
@.**** commented on this pull request.
Longitudes go from -180 to +180. This current check restrict the time zone east of Chicago and west of India (roughly).
The local city feature does not currently work for East Asia (China, Japan) or California for example.
Hopefully this change will fix this. Thanks for considering it.
— Reply to this email directly, view it on GitHub https://github.com/warmsound/crystal-face/pull/209#pullrequestreview-1632029382, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALYXESXLNTMTB5ETZDWHHT3X3C6LLANCNFSM5ESSMNUQ . You are receiving this because you authored the thread.Message ID: @.***>
AdrienChenu
⚠️ GitGuardian has uncovered 3 secrets following the scan of your pull request.
Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.
Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard. Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.
🔎 Detected hardcoded secrets in your pull request
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | | | -------------- | ------------------ | ------------------------------ | ---------------- | --------------- | -------------------- | | [472105](https://dashboard.gitguardian.com/workspace/100304/incidents/472105) | Triggered | OpenWeatherMap Token | 29b43bfa980549ba999796b92317f453d67e862f | source/BackgroundService.mc | [View secret](https://github.com/warmsound/crystal-face/commit/29b43bfa980549ba999796b92317f453d67e862f#diff-4fac524b9a48737020b84e35b525f4c1e364d0f71804ba71acaaf56846582a72R139) | | [472105](https://dashboard.gitguardian.com/workspace/100304/incidents/472105) | Triggered | OpenWeatherMap Token | d1266be0fbd63bf3eaa5affd92306f06cb603dd1 | source/BackgroundService.mc | [View secret](https://github.com/warmsound/crystal-face/commit/d1266be0fbd63bf3eaa5affd92306f06cb603dd1#diff-4fac524b9a48737020b84e35b525f4c1e364d0f71804ba71acaaf56846582a72R117) | | [472105](https://dashboard.gitguardian.com/workspace/100304/incidents/472105) | Triggered | OpenWeatherMap Token | d1266be0fbd63bf3eaa5affd92306f06cb603dd1 | source/BackgroundService.mc | [View secret](https://github.com/warmsound/crystal-face/commit/d1266be0fbd63bf3eaa5affd92306f06cb603dd1#diff-4fac524b9a48737020b84e35b525f4c1e364d0f71804ba71acaaf56846582a72L121) |
🛠 Guidelines to remediate hardcoded secrets
1. Understand the implications of revoking this secret by investigating where it is used in your code. 2. Replace and store your secrets safely. [Learn here](https://blog.gitguardian.com/secrets-api-management?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) the best practices. 3. Revoke and [rotate these secrets](https://docs.gitguardian.com/secrets-detection/secrets-detection-engine/detectors/specifics/open_weather_map#revoke-the-secret?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). 4. If possible, [rewrite git history](https://blog.gitguardian.com/rewriting-git-history-cheatsheet?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data. To avoid such incidents in the future consider - following these [best practices](https://blog.gitguardian.com/secrets-api-management/?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) for managing and storing secrets including API keys and other credentials - install [secret detection on pre-commit](https://docs.gitguardian.com/ggshield-docs/integrations/git-hooks/pre-commit?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.