search

warmspringwinds / pytorch-segmentation-detection

Image Segmentation and Object Detection in Pytorch
MIT License
746 stars 170 forks source link

Help cleans resnet train.ipynb -- use relative path imports, rid ACT module #6

Closed peteflorence closed 6 years ago

peteflorence commented 6 years ago

Hey there, thanks for this great repo. Very easy to use and clean implementation.

This tiny PR cleans a couple things that might be helpful for others. It brings in the nice relative path imports in other notebooks that weren't in resnet_34_8s_train.ipynb. Also there was an import from adaptive_computation_time, but this module isn't needed.

If I get around to it later I might also help add some documentation on setting up VOC for use with this repo.

Cheers!

peteflorence commented 6 years ago

Also just tacked on a small fix to README

warmspringwinds commented 6 years ago

Thank you, @peteflorence !

Have a look at my comment

warmspringwinds commented 6 years ago

@peteflorence I have just realized that you did it much easier for other people to use.

Thank you

peteflorence commented 6 years ago

Very good!

I've used your repo as a building block in a new project, hopefully will open source that soon

warmspringwinds commented 6 years ago

@peteflorence I am glad this repo worked for you :) Great :) Let me know if you do, I would love to have a look

peteflorence commented 6 years ago

Hey @warmspringwinds, circling back on this, we just had our project go live that built in part off this repo.

Here is code, video, arXiv pre-print.

Your repo was very helpful -- my first version of training up our networks used a derived version of your training notebook, just with new pre-processing and loss function swapped in (we are doing a different task than segmentation).

Cheers!, Pete

warmspringwinds commented 6 years ago

@peteflorence That's a great work! I will have a more thorough look these days for sure!

I am glad that my work was useful for you :+1: