warner / foolscap

remote object-messaging for Python+Twisted
http://foolscap.lothar.com/trac
MIT License
51 stars 40 forks source link

appserver: remote_putfile uses bytes on wire #64

Closed warner closed 4 years ago

warner commented 4 years ago

and converts into a native str upon receipt

Hopefully this will enable "flappclient upload-file" to work between py2/py3 systems, but I haven't tested it yet.

codecov-io commented 4 years ago

Codecov Report

Merging #64 into master will increase coverage by <.01%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #64      +/-   ##
==========================================
+ Coverage   84.36%   84.36%   +<.01%     
==========================================
  Files          58       58              
  Lines        8801     8803       +2     
  Branches     1381     1381              
==========================================
+ Hits         7425     7427       +2     
  Misses        993      993              
  Partials      383      383
Impacted Files Coverage Δ
src/foolscap/appserver/client.py 76.88% <100%> (ø) :arrow_up:
src/foolscap/appserver/services.py 88.2% <100%> (+0.12%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b32cb13...8907ac6. Read the comment docs.