search

warner / foolscap

remote object-messaging for Python+Twisted
http://foolscap.lothar.com/trac
MIT License
51 stars 40 forks source link

Wheel release of 20.4.0 on pypi contains old i2p code #70

Open sajith opened 4 years ago

sajith commented 4 years ago

i2p should have gone in foolscap 20.4.0, but at least foolscap/connections/i2p.py is present in the .whl file. The corresponding .zip file does not contain that.

Quick test:

$ wget https://files.pythonhosted.org/packages/82/f8/be775e689bd579b102a9b7aa731fac8726e27f97a2659481098488e3eac3/foolscap-20.4.0-py2.py3-none-any.whl
$ unzip foolscap-20.4.0-py2.py3-none-any.whl
$ find . -name "i2p.py"
./foolscap/connections/i2p.py

(This is related to https://github.com/tahoe-lafs/tahoe-lafs/pull/700)

exarkun commented 4 years ago

The fallout for Tahoe-LAFS right now is that after upgrading the Foolscap dependency, CI appears to be green almost across the board. Only two CI configurations which by chance didn't use the wheel from PyPI encountered I2P-related errors. The rest of CI claims Tahoe-LAFS I2P will continue to work with Foolscap 20.4.0 which, if true at all, appears to be unintended (and since the reason I2P support was dropped was lack of Python 3 support, will probably not remain true; also users installing Foolscap differently will get different results).