search

warner / python-ed25519

Python bindings to the Ed25519 public-key signature system
Other
164 stars 38 forks source link

add python 3 support #6

Closed bit closed 10 years ago

bit commented 10 years ago

this patchset adds support for python3 wile still working with python2. print_function is imported from future, this makes python2.6 the earliest version that should work (only tested with python2.7 and python 3.4)

bit commented 10 years ago

Tested with python 2.6.9 and edsig generate/sign/verify work

warner commented 10 years ago

awesome, thanks! I pushed a branch ("pr6") that adds travis coverage for py3.3 and py3.4, and it looks like travis is failing the tests (https://travis-ci.org/warner/python-ed25519/jobs/34548927). Any idea what's going on here? (btw if you pull that last commit into your PR branch, then any changes you push ought to trigger travis tests too, and travis ought to drop a comment here with the results).

What versions of python ought this to work with? 3.2? just 3.4? We should also update the README with those versions. Thanks!

bit commented 10 years ago

Ups, did not run tests with py3, just tested with my code and edsig, now tests also work with python 2 and 3.

Updated README, not sure about python 3.2, don;t have a copy around, but could enable it on travis and see if it fails.

bit commented 10 years ago

Tested with a local build of python 3.2.5 and it fails since base64.b64decode does not work with bytes but still expects strings. Given that I would suggest to only support 3.3, 3.4.

warner commented 10 years ago

Ok, looks good. I'm going to merge this, but I'll do a pass before the next release to make sure there aren't any regressions in the str-vs-unicode behaviors for 2.6/2.7. I also need to look at versioneer.py: it's supposed to work with py3 already (although maybe the copy in python-ed25519 is too old to pick that up). Thanks!