warp-drive-engineering / engage

Scaffolding for highly optimized applications built with Ember.js
MIT License
26 stars 0 forks source link

lint:fix script not present in app package.json #3

Open knownasilya opened 2 years ago

knownasilya commented 2 years ago

ember-cli expects a lint:fix script which it uses when running blueprint generators, like ember g helper test. It returns this message:

WARNING: Lint fix skipped: "lint:fix" not found in package.json scripts. New files might not pass linting.
runspired commented 2 years ago

we may want to stub it to do nothing, else we'll want it to run lint from the root level vs from within the app/addon.

That said I feel it's likely we replace the default ember blueprints with engage versions, should speed up the process not having all the ember cruft in the blueprint timeline making scaffolding nicer all around, and that way we can match output to the conventions of the pod setup that apps are configured for (pods for route templates/files/controllers only, classic/co-location everything else)

knownasilya commented 2 years ago

I like that.