warpdotdev / Warp

Warp is a modern, Rust-based terminal with AI built in so you and your team can build great software, faster.
https://warp.dev
Other
20.41k stars 338 forks source link

Ability to remove / unset / clear a keyboard shortcut / keybinding #1037

Closed rootulp closed 1 year ago

rootulp commented 2 years ago

Discord username (optional)

rootulp#9326

Describe the solution you'd like?

I'd like the ability to clear a keyboard shortcut. After clearing a keyboard shortcut, I would expect no keybindings to trigger the command.

Is your feature request related to a problem? Please describe.

No response

Additional context

I use CMD + K for a keybinding outside Warp. I'd like to completely remove the keybinding associated with the Clear blocks command in order for the keybindings to not conflict.

Screen Shot 2022-04-13 at 1 57 33 PM
rootulp commented 2 years ago

This may manifest as a "Clear" option next to "Reset to default". Another option is to display a menu on right click of the keybinding with the option to "Clear".

paustint commented 2 years ago

+1

hasanyasin commented 2 years ago

I could see that there is a file (~/.warp/keybindings.yaml on MacOS) where custom key bindings are written and I tried setting the shortcut that I want to remove to some invalid value like "null" or empty string, but the application ignored those invalid overrides.

What I ended up as a workaround is to set all the shortcuts to a value that I would never use such as ctrl-alt-shift-cmd-f16 (which most keyboards can't even do for the lack of F16 key) and the app accepted it as a valid value, hence the shortcut is basically eliminated.

Plus, setting the same value to all the ones you want to disable also works. On the settings tab, it shows those as conflicts but since you want to disable them anyways, you wouldn't care, I believe. :D

EdmundsEcho commented 2 years ago

@elviskahoro I'm not sure if the basis for closing this issue was because Warp now supports "clearing" a keybinding or not. I'm a new user. When setting my keybindings, there was no way to literally "clear" whatever entry was associated with a keybinding. "clear" means some keybinding -> empty and thus available for use elsewhere. Thanks for clarifying.

elviskahoro commented 2 years ago

@hasanyasin @EdmundsEcho @rootulp @paustint Didn't mean to close! Thanks for commenting. I think I accidentally closed both issues (there was a duplicate) instead of just one.

elviskahoro commented 2 years ago

Yep. just checked internally and I had left it open. This was definitely an accident!

warpdotdev-devx commented 1 year ago

Duplicate: GitHub issue for disabling a keyboard shortcut: https://github.com/warpdotdev/Warp/issues/796

Will close this in favor of that one.

--- original message --- On April 13, 2022, 2:01 PM EDT @.*** wrote:

This may manifest as a "Clear" option next to "Reset to default". Another option is to display a menu on right click of the keybinding with the option to "Clear".

Reply to this email directly, view it on GitHub, or unsubscribe.

You are receiving this because you are subscribed to this thread.Message ID: @.***>

-- You received this message because you are subscribed to the Google Groups "github" group. To unsubscribe from this group and stop receiving emails from it, send an email to @.*** --- end of original message ---

dannyneira commented 1 year ago

Hey Folks, this feature is actively being worked on along with other enhancements to setting KB shortcuts in general, no eta on release but it's on the roadmap 🚀

Sneak preview ( not final ):

CleanShot 2023-02-10 at 11 21 04

alokedesai commented 1 year ago

Marking this as closed since this has been launched for a while. Please let me know if you are experiencing any issues with this!

warpdotdev-devx[bot] commented 1 year ago

👍 We have more on keyboard shortcuts in our docs: https://docs.warp.dev/features/keyboard-shortcuts