Add alternatives to google's identity toolkit for Chinese developers

Evian-Zhang commented 2 years ago

Discord username (optional)

No response

Describe the solution you'd like?

Currently, after installing warp, we need to sign in or sign up. Current implementation requires access to https://www.googleapis.com/identitytoolkit, which **is inaccessible to Chinese developer** without using certain proxies or VPNs. Not all Chinese developers have such things and setting up those things requires additional efforts. Please consider adding an alternative to google's identity toolkit which can be accessed in China.

Is your feature request related to a problem? Please describe.

No response

Additional context

No response

alokedesai commented 2 years ago

Hi @Evian-Zhang, thanks for flagging. Would you mind checking if this is fixed? We now proxy this request through our own server to get around this.

Evian-Zhang commented 2 years ago

Hi @Evian-Zhang, thanks for flagging. Would you mind checking if this is fixed? We now proxy this request through our own server to get around this.

@alokedesai Unfortunately, login still does not work. My Warp version: 0.2022.05.09.09.06.stable_01 (downloaded via homebrew), OS: macOS 12.4.

When I click "Sign Up" button in Warp app, it takes me to https://app.warp.dev/signup/remote?scheme=warp&public_beta=true with my default browser. I have tested this url in different browsers:

In Safari:
- Clicking "Continue with GitHub" will pop up a sub frame, inside which it fetches https://www.googleapis.com/identitytoolkit/v3/relyingparty/getProjectConfig and https://www.googleapis.com/identitytoolkit/v3/relyingparty/config
- Clicking "Continue with email" will fetch https://identitytoolkit.googleapis.com/v1/accounts:sendOobCode
In Chrome, Firefox, etc.
- Clicking "Continue with GitHub" will fetch https://apis.google.com/js/api.js?onload=__iframefcb775316 (which I don't know what it is), and this url is not accessible here.
- Clicking "Continue with email" will fetch https://identitytoolkit.googleapis.com/v1/accounts:sendOobCode

elviskahoro commented 2 years ago

Should be fixed!

Evian-Zhang commented 2 years ago

@elviskahoro

Currently, https://app.warp.dev/signup/remote?scheme=warp&public_beta=true still send requests to google's identity toolkit, and my Warp version is up-to-date as v0.2022.06.27.09.14.stable_01.

alokedesai commented 2 years ago

@Evian-Zhang Yep you are correct--reopening until we have a full fix for this

elviskahoro commented 2 years ago

Thanks @Evian-Zhang

warpdotdev / Warp