warpdotdev / Warp

Warp is a modern, Rust-based terminal with AI built in so you and your team can build great software, faster.
https://warp.dev
Other
20.98k stars 359 forks source link

Poor UTF-8 support #1261

Open permezel opened 2 years ago

permezel commented 2 years ago

Discord username (optional)

No response

Describe the bug

When interfacing with command completion, the UTF-8 encoding is presented in a weird, unnatural form, specifically for Japanese characters.

To Reproduce

Steps to reproduce:

  1. cd /tmp
  2. mkdir -p warped/天ぷら先生
  3. cd warped
  4. ls
  5. Observe that the ぷ is rendered as ふ
  6. Type 'cd TAB'
  7. Note the confusing mess warped

Expected behaviour

See the attached screen shot for terminal.app

Screenshots

image

Operating System

MacOS

OS Version

12.3.1

Additional context

No response

Warp Internal (ignore): linear-label:24888f54-df93-45d5-9bdd-e38f740cac19

No response

permezel commented 2 years ago

Here's the same thing done in the /tmp dir. Note the missing circle thing on the ぷ from the ls and ls -l.

Note the horrible rendition of the UTF-8 string for the TAB completion.

image
permezel commented 2 years ago

For some reason, the keyboard handling for inputting JA chars is also less than desired. Here's "mkdir みく" in terminal:

image

and in warp: If I just typed "mkdir み" I get:

image

It totally obscures the input, making things rather difficult.

permezel commented 2 years ago

If I try using vi to edit some text, and enter わたし, a popup appears at the bottom left of the screen, not at the top where I am typing (and thus focused):

image

Contrast to Terminal.app:

image

All the action happens at the insertion point, and the input string is not obscured.

permezel commented 2 years ago

This might help. I use a standard US-ascii keyboard (on MacBookPro) but install some Japanese keyboard input methods.

image image
dev4joel commented 2 years ago

From TwinbornBoat217 via Discord https://discord.com/channels/851854972600451112/852249738002956311/973916158711431201

suggests weren't showing correctly during typing with Japanese input methods Also the word are not displayed until I press the enter key

elviskahoro commented 2 years ago

Thanks for sending all this info offer. will circle back with updates once we have them!

argentini commented 1 year ago

Any word on this? My app, SQribe, doesn't output the UTF graphics characters it uses for the UI.

warp-utf terminal-utf
obregonia1 commented 1 year ago

If I try using vi to edit some text, and enter わたし, a popup appears at the bottom left of the screen, not at the top where I am typing (and thus focused):

image

Contrast to Terminal.app: image

All the action happens at the insertion point, and the input string is not obscured.


@elviskahoro I would be happy to see this issue resolved! My screenshots below.

Warp

image

iTerm2

image