search

warpdotdev / Warp

Warp is a modern, Rust-based terminal with AI built in so you and your team can build great software, faster.
https://warp.dev
Other
21.39k stars 374 forks source link

'Secondary click' (aka control-click) in the text editor doesn't work #1852

Open jrdodds opened 2 years ago

jrdodds commented 2 years ago

Discord username (optional)

No response

Describe the bug

When I'm entering new input and I 'secondary click' (which is often configured as a right-click on a mouse) in the text editor, nothing happens. (I'm not actually sure if this is a Bug or a Missing Feature.)

When I secondary click on an existing completed block in Warp, a non-native context menu is displayed with menu choices that include various types of 'Copy'. In the text editor in Warp there is no context menu on a secondary click. To paste in the text editor, I have to use the Edit menu or switch from the mouse/trackpad to the keyboard.

With Terminal, for example, I can copy a command from a web page, move the pointer from the web page window to the terminal window, secondary click, and choose paste from the context menu all with the mouse or trackpad.

To Reproduce

  1. Select and copy some text.
  2. Open Warp.
  3. In the text editor pane, 'secondary click' in the pane. (The secondary click, given default OS settings, can be a control-click, a mouse right-click, or a trackpad two-finger click.)
  4. Observe that the secondary click is not handled.

Expected behaviour

At a minimum display a context menu with a 'Paste' choice that will insert the clipboard at the current insertion point. A 'Copy' choice would also make sense.

Screenshots

This is a screenshot of the context menu from the Terminal app:

Screen Shot 2022-09-20 at 7 16 40 PM

Operating System

MacOS

OS Version

12.6

Shell Version

zsh 5.8.1 (x86_64-apple-darwin21.0)

Warp Version

v0.2022.09.13.08.15.stable_03

Additional context

No response

Does this block you from using Warp daily?

No

Warp Internal (ignore): linear-label:b8107fdf-ba31-488d-b103-d271c89cac3e

No response

dannyneira commented 2 years ago

Hi @jrdodds, I'm marking this one as a feature request. Please +1 this request as it helps us gauge interest. We will post any updates here.

jrdodds commented 2 years ago

I'm glad this is getting attention. I did consider this as a feature request and I understand that the claim that "Warp is a fully native, GPU-accelerated, Rust-based terminal" is not intended to mean that Warp is a native macOS UI app. But I did arrive on creating this issue as a bug because Warp is breaking a macOS UI expectation.