search

warpdotdev / Warp

Warp is a modern, Rust-based terminal with AI built in so you and your team can build great software, faster.
https://warp.dev
Other
20.98k stars 359 forks source link

Prevent Command+W #1887

Open dgbhat opened 1 year ago

dgbhat commented 1 year ago

Discord username (optional)

No response

Describe the solution you'd like?

Warp is fantastic! Please please add this highly important feature (as an option). 
When I click on Command + W, I do not want the Warp tab to be closed immediately. Let it prompt if I really want to close the tab. Please add this feature. This is also present as an option in the Mac Terminal. This saves me alottt of times.

Is your feature request related to a problem? Please describe.

I lose all my progress when I click on Command W since I can not just reopen like a browser tab. So just adding a prompt before closing the tab would do.

Additional context

No response

How important is this feature to you?

4

Warp Internal (ignore) - linear-label:770f6576-d6c0-4e4f-a259-fc64b5156087

No response

dannyneira commented 1 year ago

Thanks for this feature request! Please +1 this request as it helps us gauge interest. We will post any updates here.

semihcosu commented 1 year ago

Addition to this, it could be great to only activate this option for tabs with ongoing commands. For example, I accidentally closed a lot of tabs with nodemon running.

NTMan commented 1 year ago

I like how it implemented in Gnome Terminal

Screenshot from 2022-11-14 04-28-25

timdang commented 1 year ago

I'd also like a warning when clicking the X to close a tab if there's a process running. Thanks.

ADTC commented 1 month ago

Accidentally clicked X on a tab. Realized I need this!

Unlike closing a web browser tab (which you can re-open and restore exactly as it was, and which now has a "Reopen last closed tab" feature in some form), the loss of data on closing a Tab with a Terminal session is much much higher. The stakes are a lot higher.

Please, implement this for the sanity of your users. It's not a nice-to-have, but a Must-Have. Thank you.

ADTC commented 1 month ago

This video from @EvHaus perfectly illustrates why we need this. Please play it with sound so you don't miss the "OMG what a nightmare" 😂

(comment from @EvHaus quoted below)

For tabs that have a running process (like alt-screen or servers, etc), we have the Quit Warning feature here.

This doesn't work for me. Here's the problem:

https://github.com/warpdotdev/Warp/assets/226640/f5f4f46b-3c73-4e12-bdef-052c8f9f0356

@dannyneira Would you please consider re-opening this issue? Or do you think it's better to open a new one?

Originally posted by @EvHaus in https://github.com/warpdotdev/Warp/issues/2717#issuecomment-1973752129

dgbhat commented 1 month ago

This video from @EvHaus perfectly illustrates why we need this. Please play it with sound so you don't miss the "OMG what a nightmare" 😂

(comment from @EvHaus quoted below)

For tabs that have a running process (like alt-screen or servers, etc), we have the Quit Warning feature here.

This doesn't work for me. Here's the problem:

2024-03-01.10-53-52.mp4 @dannyneira Would you please consider re-opening this issue? Or do you think it's better to open a new one?

Originally posted by @EvHaus in #2717 (comment)

That's the perfect depiction, thanks