warpdotdev / Warp

Warp is a modern, Rust-based terminal with AI built in so you and your team can build great software, faster.
https://warp.dev
Other
21.29k stars 371 forks source link

SSH wrapper doesn't seem to do anything useful #1926

Open tomasruud opened 2 years ago

tomasruud commented 2 years ago

Discord username (optional)

No response

Local Shell and Version

zsh 5.8.1

Remote Shell and Version

bash 4.4.20(1)-release

Operating System and Version

MacOS Monterey 12.6

Warp Version

v0.2022.09.27.08.11.stable_00

I have tried commenting out my system & user rcfiles and warp still will not bootstrap

Screenshots

How Warp looks before running SSH command:

image

How it looks once logged in:

image

Include shell xtrace output

WARP_DEBUG_MODE=1 ssh example.com
bash-4.4$

Warp Internal (ignore) - linear-label:e7dfaa84-5fdb-4a00-b754-d8912da923fa

No response

dannyneira commented 2 years ago

Hi @tomasruud , So sorry to hear about this. So the SSH wrapper adds the blocks and other functionality to your SSH sessions but can produce issues if you have some custom prompt in the remote server ~/.bashrc | ~/.zshrc files.

My guess is that you normally have a custom prompt and that Warp is unable to parse it. 

You can check whether it’s something in your dotfiles by setting up clean configs: Set ZDOTDIR=/ in your ~/.zshenv file. This forces Zsh to run with zero configs.

You can disable parts of your dotfiles just for Warp by using this conditional statement:


if [[ $TERM_PROGRAM != "WarpTerminal" ]]; then
##### WHAT YOU WANT TO DISABLE FOR WARP - BELOW

# Whatever you want to disable

##### WHAT YOU WANT TO DISABLE FOR WARP - ABOVE
fi

We have a list of incompatible tools here: https://docs.warp.dev/help/known-issues#list-of-incompatible-tools And more info on custom prompts here: https://docs.warp.dev/features/prompt

Let me know if these help in any way to resolve your issue.

tomasruud commented 2 years ago

I don't have a custom prompt, and it seems like the issue still persists when I run Zsh with zero config. However, I tested with a different server, and it seems like the issue might be related to the server I'm trying to connect to. I've removed bashrc files etc from that server, but I guess it might be something related to the version the server is running?

dannyneira commented 2 years ago

Yeah, it sounds like could be the case just on that server, might have some plugin or prompt that Warp can't parse correctly.

Check our SSH GitHub milestone to see if your issue has already been reported. 

Meanwhile, you can disable the SSH wrapper by navigating to Settings > Features. Blocks will stop working but with it disabled, SSH should work as normal.

tomasruud commented 2 years ago

@dannyneira is there any debug info from the server or my local machine that I can provide you with to see if this is related to one of the other issues? I can't really say I see my issue listed there, but it might be I'm not understanding the problem properly.

dannyneira commented 1 year ago

Hi @tomasruud, My mistake, just noticed you're using bash so the clean config won't work, try moving the .bashrc file on your remote machine temporarily and let us know if that helps.

if [[ $TERM_PROGRAM != "WarpTerminal" ]]; then
 ##### WHAT YOU WANT TO DISABLE FOR WARP - BELOW

 # Whatever you want to disable

 ##### WHAT YOU WANT TO DISABLE FOR WARP - ABOVE
 fi
tomasruud commented 1 year ago

I tried doing this, but the result is still the same. I'm unsure what else could be the issue.