Multi-character emojis are not rendered properly as part of PS1

warpdotdev / Warp

Warp is a modern, Rust-based terminal with AI built in so you and your team can build great software, faster.

https://warp.dev

Other

20.86k stars 355 forks source link

Multi-character emojis are not rendered properly as part of PS1 #1995

Open svsool opened 1 year ago

svsool commented 1 year ago

Discord username (optional)

No response

Describe the bug

Compare how the following emojis are shown in iTerm (top) vs Warp (bottom).

To Reproduce

Try to use this emoji or this one as part of PS1.

Expected behaviour

Emojis rendered properly.

Screenshots

No response

Operating System

MacOS

OS Version

12.3

Shell Version

bash 5.1.16

Warp Version

v0.2022.10.11.08.13.stable_01

Additional context

No response

Does this block you from using Warp daily?

Warp Internal (ignore): linear-label:b8107fdf-ba31-488d-b103-d271c89cac3e

No response

gilmoregrills commented 1 year ago

I also have this problem with emojis that have modifiers like the man/woman ones, like 💁‍♀️ would show up as 💁 plus a ♀

dannyneira commented 1 year ago

Thanks for letting us know, we will post updates here on the status of this. by any chance is this better in newer versions of warp?

svsool commented 1 year ago

Thanks for letting us know, we will post updates here on the status of this. by any chance is this better in newer versions of warp?

Doesn't work as before.

should show these symbols instead:

@dannyneira

dannyneira commented 1 year ago

Hm i wonder if it may have something to do with the font. Try one of these and see if it helps some. https://www.nerdfonts.com/

svsool commented 1 year ago

Hm i wonder if it may have something to do with the font. Try one of these and see if it helps some. nerdfonts.com

Hack Nerd Font seemed to work, weird that Hack (default) doesn't work OOTB, and works in iTerm though.

Update: perhaps partially, seems like this emoji ☸️ is not rendered properly still 🤔 .

dannyneira commented 1 year ago

thanks for testing/letting us know.

kg-currenxie commented 1 year ago

yep, another one if it helps :) ▶️

warp

iterm

warpdotdev-devx[bot] commented 1 year ago

Thanks for the feedback!

Please subscribe to or GitHub Watch this issue so you're automatically notified when we share updates: There's difficulty with building a truly native integration with VS Code for the same reasons that Warp is different from regular terminals. Deeper integration is feasible once there's a WASM version of Warp.

0xbentang commented 1 year ago

Is Wrap having some fonts built-in? None of the nerd fonts in the menu works for me...

Then when I check "View all available system fonts", some of the fonts I installed myself (fire code nerd font, hack nerd font) show up and they all work