Prompt in one line / Cursor in the same line with the prompt

AMATEURTOSS commented 1 year ago

[WARP] Note to all users opening this issue:

It is live 🎉 ! Check out https://github.com/warpdotdev/Warp/issues/2304#issuecomment-2223352668 for the latest update! And check out this post for a behind-the-scenes dive!
We're slowly rolling this out to folks, to ensure stability! Please see the comment here!
Please see prior update from Warp here. This is actively being worked on.

is there any option to make prompt in one line?

current behavior

~/some/location
something command -option

one line prompt

~/some/location > something command -option

How important is this feature to you?

1 (Not too important)

jordantshaw commented 6 months ago

Any ETA on this? Great product, but annoying extra lines when using starship keeping me from switching over to warp full time.

Advait-M commented 6 months ago

Any ETA on this? Great product, but annoying extra lines when using starship keeping me from switching over to warp full time.

Hey there 👋 ! Thanks for the feedback. No concrete ETA for release, but I can say that I'm continuing to actively work on getting this over the finish line.

If folks are interested: I won't dive too deep into the technical complexity here (I might consider a blog post later if there's enough interest 👀 ) - but TL;DR is that this has led to a much bigger refactor/reworking of underlying core terminal rendering logic than initially expected, largely due to 2 points:

Properly interweaving a "traditional prompt grid" with Warp's modern input editor presents some unique UI challenges with respect to aspects such as soft-wrapping text, handling scrolling, selections, multi-line lprompts and rprompts.
Presenting a "traditional" layout in finished blocks (i.e. past commands), where the prompt/command are "one entity" from a text layout/grid POV, but Warp is still able to differentiate between the two concepts for many other dependencies in the application, e.g. the "Copy Command" action, also presents numerous unique challenges across the 3 shells we support (zsh, bash & fish) and any prompt plugins we support e.g. powerlevel10k.

This issue in particular is something where we want very high confidence in no regressions before release as well, since it directly affects the core terminal experience and any dependencies.

Thanks to everyone for indicating their interest in this feature and giving their thoughts (keep them coming as relevant!) ❤️ . I'll be sure to ping this thread 🔔 when we do include this into a new Warp release (especially for folks who currently aren't able to use Warp due to this)!

TimAnthonyAlexander commented 5 months ago

+1

haristhohir commented 5 months ago

+1

yatanasov commented 5 months ago

+1

martylukyy commented 5 months ago

+1

sngtn commented 5 months ago

+1

earmellin commented 5 months ago

1

KoderFPV commented 5 months ago

+1

luizeboli commented 5 months ago

Hey everyone, pls stop spamming +1, you are annoying almost 50 people with useless notifications and just flooding the issue. Reacting to the main post should be enough.

The team already said they are working on this, let's be patient 🙏🏽

Advait-M commented 5 months ago

Thanks! Yep, we're still working on this (working through supporting each of the shells + cases like subshells and SSH currently) and just a note to add onto what @luizeboli said: if you'd just like to subscribe to the issue for notifications, you can do that without commenting by using the sidebar in GitHub (on the right) - would recommend to follow along! See screenshot:

jimcornmell commented 5 months ago

+1. Please make the prompt 1 line.... looks rubbish over 2 lines and takes too much room

Guillermogsjc commented 5 months ago

please do this feature, warp is awesome but this non-configurable and opposed to terminal standards appearance makes quite confusing to work with it

Guillermogsjc commented 5 months ago

I just do not understand the downvotes on the positive feedback of this feature.

Standard terminals have prompts in one line and users are used to this. It is everywhere, on console on cloud, on every other cmd prompts.

The only needed thing is to set this "one prompt line" as a configurable toggle in appearance, as it is with many other useful customizable things already. This application is great, and this would make it even more great :)

Which is the problem of having this point also as configurable?

AlecRust commented 5 months ago

The downvotes are because spamming this issue with comments is unnecessary and notifies everyone.

This was clearly stated in https://github.com/warpdotdev/Warp/issues/2304#issuecomment-1961186776. People ignored that, and continued adding "+1" comments 🤦

FWIW I would lock this issue, it's very clear what the request is.

Advait-M commented 5 months ago

Yep, let me lock this thread until we can post further updates on releasing this feature 🔒 ! Note the most recent update is here (briefly outlines why this is technically challenging in the context of Warp - essentially constitutes a rework of core Warp logic).

Thanks for all the feedback folks - if there's other different prompt-related issues, please open a new issue (but if it's pertaining to this topic, we're on it!)

Advait-M commented 1 month ago

Howdy folks! Quick update: I've got some good news 😄

We’ve started the roll-out of same line prompt (SLP) with yesterday’s release (v0.2024.06.18.08.02.stable_03) - this will be enforced for PS1 (custom prompts) and opt-in for Warp prompt (via Edit Prompt). Please note that this is a very large refactor of core Warp code behind-the-scenes - as such, we’re limiting this to a 10% randomized roll-out currently. No concrete ETA on when we expect the roll-out to be complete.

My own Warp session after updating to the new build 👀 :

If you are in the roll-out and you notice any bugs/regressions, please report them to us (ideally, make a new GitHub issue and then link it in this thread)! Thanks folks!

I'm opening this thread back up for any feedback! Please avoid "+1"s, as mentioned above (use GitHub's "Subscribe" to issue feature + :+1: the original post instead)! Additionally, we will not be adding folks into this roll-out on a voluntary basis - please be patient with us, as we ensure stability and roll this out!

mboeker commented 1 month ago

YAY!! Where can this setting be enabled?

ashebanow commented 1 month ago

Awesome news, can't wait to try it out!

On Fri, Jun 21, 2024 at 8:49 AM Martin Ananda Boeker < @.***> wrote:

YAY!! Where can this setting be enabled?

— Reply to this email directly, view it on GitHub https://github.com/warpdotdev/Warp/issues/2304#issuecomment-2183007313, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAACX73FJCZ2YVJ4C3M7ESDZIRDR3AVCNFSM6AAAAAASVMBPTCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOBTGAYDOMZRGM . You are receiving this because you are subscribed to this thread.Message ID: @.***>

daUnknownCoder commented 1 month ago

Hey @Advait-M, can u tell me where's the upvote feature? I guess I forgot it's location, if anyone finds it, press it 1000 times for me

Advait-M commented 1 month ago

YAY!! Where can this setting be enabled?

@mboeker If you're in the 10% roll-out, you'll see it pop up in the Edit Prompt modal for Warp prompt (Settings > Appearance > Prompt or Command Palette)! For PS1 (shell prompt), it'll automatically be converted to same line prompt (since we want to respect your shell prompt exactly!).

Hey @Advait-M, can u tell me where's the upvote feature? I guess I forgot it's location, if anyone finds it, press it 1000 times for me

@daUnknownCoder haha - it's right here (top of this thread - 👍 ):

But yep, we've already noted this is very important for users hence we're working on launching this fully 😄 !

mboeker commented 1 month ago

Okay thanks!

On Fri, Jun 21, 2024, 18:06 Advait Maybhate @.***> wrote:

YAY!! Where can this setting be enabled?

@mboeker https://github.com/mboeker If you're in the 10% roll-out, you'll see it pop up in the Edit Prompt modal for Warp prompt! For PS1 (shell prompt), it'll automatically be converted to same line prompt (since we want to respect your shell prompt exactly!).

image.png (view on web) https://github.com/warpdotdev/Warp/assets/12927474/a7010345-41b7-4b6c-9eb6-e9efd38fefef

Hey @Advait-M https://github.com/Advait-M, can u tell me where's the upvote feature? I guess I forgot it's location, if anyone finds it, press it 1000 times for me

@daUnknownCoder https://github.com/daUnknownCoder haha - it's right here (top of this thread - 👍 ): image.png (view on web) https://github.com/warpdotdev/Warp/assets/12927474/0d124174-f0f7-4607-a81b-096d0cd80e29

— Reply to this email directly, view it on GitHub https://github.com/warpdotdev/Warp/issues/2304#issuecomment-2183032592, or unsubscribe https://github.com/notifications/unsubscribe-auth/AE3BVJ7YOB7YUSPK7QFGVJLZIRFPNAVCNFSM6AAAAAASVMBPTCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOBTGAZTENJZGI . You are receiving this because you were mentioned.Message ID: @.***>

damongolding commented 1 month ago

Awesome thanks!

I'm not in the 10% so I shall have to begrudgingly wait

daUnknownCoder commented 1 month ago

guess what, @Advait-M, find happiness in this photo:

Advait-M commented 1 month ago

guess what, @Advait-M, find happiness in this photo:

Haha - to clarify explicitly: everyone is expected to receive this version update. However, only 10% of folks (once on this version) will be included in the experimental roll-out of same line prompt currently! So it may be the case that you update and you don't see SLP yet!

daUnknownCoder commented 1 month ago

okay so i updated and idk how to migrate to the build u r on? i dont know how to be in the 10%? @Advait-M

damongolding commented 1 month ago

…you have to wait On 21 Jun 2024 at 6:00 PM +0100, StellarCoder @.***>, wrote:

okay so i updated and idk how to migrate to the build u r on? i dont know how to be in the 10%? @Advait-M — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you are subscribed to this thread.Message ID: @.***>

Advait-M commented 1 month ago

okay so i updated and idk how to migrate to the build u r on? i dont know how to be in the 10%? @Advait-M

It's purely random currently i.e. you can't voluntarily migrate unfortunately. This is for stability reasons, as noted above, we want to ensure all of Warp's functionality is good to go before we do a larger roll-out. I'll update this thread when we do decide to do a 100% roll-out (my current best guess is in the next ~month but there's various factors at play here).

I appreciate the excitement from folks and I know this has been something all of you have been waiting for (as have I 😄 )!!

mfittko commented 1 month ago

damn, guess I'm in the other 90% - isn't there a way to "roll the dice" again? ;) looking forward to its public release!

daUnknownCoder commented 1 month ago

damn, guess I'm in the other 90% - isn't there a way to "roll the dice" again? ;) looking forward to its public release!

you can freely roll the dice in about a month from now, until then i'll be shipping binks brew in your boat

mboeker commented 1 month ago

I tried downloading the installer a bunch of times from different regions on different systems, they were always the same byte count, so that doesn't seem to be the trick

daUnknownCoder commented 1 month ago

I tried downloading the installer a bunch of times from different regions on different systems, they were always the same byte count, so that doesn't seem to be the trick

you actually went that far? 💀 and yeah i gave up thinking that i wasnt lucky, tho i was in their first 100 users private linux beta, i didnt get lucky this time...

and yeah @Advait-M, im not good at probability so i would like to ask on what basis do you get volunteers to get lucky? is it how much they use Warp terminal or Warp AI or some other terms? Like this luck might get passed to peeps who dont even open warp... just asking coz if its random there must be an algorithm for guessing ig

daUnknownCoder commented 1 month ago

@Advait-M:

My own Warp session after updating to the new build 👀 :

is the prompt fish+tide? or zsh+powerlevel10k? curious (if it is the former -> 2 birds with one stone, if the latter -> 0 birds with 2 stones) My own Warp session after updating to the new build 👀 :

Advait-M commented 1 month ago

and yeah @Advait-M, im not good at probability so i would like to ask on what basis do you get volunteers to get lucky? is it how much they use Warp terminal or Warp AI or some other terms? Like this luck might get passed to peeps who dont even open warp... just asking coz if its random there must be an algorithm for guessing ig

Haha - completely randomized. No particular signals being used.

@Advait-M:

My own Warp session after updating to the new build 👀 :

is the prompt fish+tide? or zsh+powerlevel10k? curious (if it is the former -> 2 birds with one stone, if the latter -> 0 birds with 2 stones) My own Warp session after updating to the new build 👀 :

This one was zsh + powerlevel10k! But yep, same line prompt will be supported across zsh, bash and fish + the goal is all prompt plugins. This is part of the reason for the roll-out - there's a massive variety of shell + prompt plugin combinations that we'd like to confirm are all looking good!

daUnknownCoder commented 1 month ago

tide + fish? #3358?

pyxelr commented 1 month ago

Finally ❤️!

I confirm that all is fine so far with my Starship prompt in zsh:

warp

By the way, here is the snippet I saw in Warp after the update for putting the newline back in PS1:

echo 'PROMPT="${PROMPT}"$'\''\\n'\''' >> ~/.zshrc

daUnknownCoder commented 1 month ago

Hey @Advait-M, ig this is solved so what about pushing this to main and focus on #239?

daUnknownCoder commented 1 month ago

If anyone knows Tho and I didn't want to open a ticket for this, if I type "hello" it won't go to agent mode, it will say unknown command

youvegotmoxie commented 1 month ago

@daUnknownCoder what does this have to do with the single line prompt?

daUnknownCoder commented 1 month ago

@daUnknownCoder what does this have to do with the single line prompt?

Yeah ik that that's why I said: If anyone knows Tho and I didn't want to open a ticket for this

I thought this was a very petty thing for a ticket to be issued

Advait-M commented 1 month ago

tide + fish? #3358?

Ooh, I think that this should be fixed as a side-effect! However, I'm not super knowledgeable with all of tide's config. I just tried it out myself and it looks good to me (a lot better than previous iteration of Warp!)

Screenshot (w/ the same line prompt rollout):

I'd love for some active tide + fish users to verify this - we can definitely do this when we do ramp up to 100% rollout later 😄 . In any case, It should be a strict improvement over the current experience!

For context, we've changed the underlying mechanisms with which we pass prompt bytes - which should result in better plugin support across the board! This rework is similar to what we did to support p10k in Zsh (however, I've done this for Bash + fish now!) 🎉

Advait-M commented 1 month ago

Hey @Advait-M, ig this is solved so what about pushing this to main and focus on #239?

We actually have prototyped ligatures support, however, there's severe performance regressions with this prototype. I believe the plan is to return to this at some point, however, no ETA on this and we're not sure when we'll be able to prioritize this (there's a few technical challenges to figure out here!).

Note that I actually did implement slightly better Unicode support as a part of same line prompt! See https://github.com/warpdotdev/Warp/issues/4191#issuecomment-2187375562 for details - we added support for correct emoji rendering with emoji presentation selectors 😄 (this unblocks Starship on fish).

Advait-M commented 1 month ago

Finally ❤️!

I confirm that all is fine so far with my Starship prompt in zsh:

By the way, here is the snippet I saw in Warp after the update for putting the newline back in PS1:
echo 'PROMPT="${PROMPT}"$'\''\\n'\''' >> ~/.zshrc

AWESOME 🎉!! Love to hear it and thanks for the positive feedback 😄

Advait-M commented 1 month ago

If anyone knows Tho and I didn't want to open a ticket for this, if I type "hello" it won't go to agent mode, it will say unknown command

Ah, this sounds like it could be a bug with Agent Mode input autodetection 👀 ? Yeah, could you please open a new GitHub issue for this and we can help you there! Thanks! 😄

Advait-M commented 3 weeks ago

Hey folks - please keep it professional. You can unsubscribe to this issue if you'd like via GitHub UI.

Otherwise, I'm hoping to keep this issue unlocked for any feedback!

As noted, I'll post an update when we roll out further - we're working through polishing some stuff up! 😀

daUnknownCoder commented 3 weeks ago

hey @Advait-M, the next message of yours should be: Rolling Out to 20% of the folks, i hope this happens soon 😃

Advait-M commented 2 weeks ago

Well folks… today’s the day y’all have been waiting for :tada:

Same Line Prompt (SLP) is officially rolling out to 100% of Warp users!! Here’s a video commemorating the release… GET HYPED!! 😀

https://github.com/warpdotdev/Warp/assets/12927474/b48e43ca-1dad-4eb7-a62b-b6fef85fe96b

Please update to v0.2024.07.09.08.01.stable_00 (latest Warp) to see the changes. Note that SLP is enforced for shell prompts (PS1) and it is opt-in for Warp prompt (via the Edit Prompt modal). Check out docs.warp.dev/appearance/prompt#same-line-prompt for our documentation on this.

Again, please report any and all bugs you see that may be related to these changes - this was a fundamental shift in core Warp infrastructure! Please open a new issue and link out to it from this thread!

Thanks for your patience on this - it’s truly been an adventure 🫡 ❤️! I’ve enjoyed the enthusiasm + feedback from y’all and it’s been instrumental in continuing my work on this haha!

We’ll also have a long-form YouTube video + blog post coming out next week that goes into a bit of a technical deep-dive into this project. Keep an eye out for that (I’ll update this thread as well)! 👀

daUnknownCoder commented 2 weeks ago

the patience to watch the full video 🫡 and the dedication of the warp team to make a video for it 🎊 looks like it really was one hell of a change to the code

wmcnamee-coreweave commented 2 weeks ago

Need some docs on how to restore the newline when using Starship. #765 has regressed basically

jordantshaw commented 2 weeks ago

Need some docs on how to restore the newline when using Starship. #765 has regressed basically

Just add the following to your starship.toml configuration file.

[line_break]
disabled = false

warpdotdev / Warp

Prompt in one line / Cursor in the same line with the prompt #2304

How important is this feature to you?