warpdotdev / Warp

Warp is a modern, Rust-based terminal with AI built in so you and your team can build great software, faster.
https://warp.dev
Other
20.93k stars 359 forks source link

Can't seem to be able to set background image #2440

Open ScopeSV opened 1 year ago

ScopeSV commented 1 year ago

Discord username (optional)

No response

Describe the bug

I cant set a background image. Following the guides. Does not work. I've tried one of the standard downloaded themes (from the git repository in the docs) which had background image commented out. Removed the comments, but no luck there either

accent: "#ff047d"
background: "#231b4d"
background_image:
  path: ~/.warp/themes/standard/30012.jpg
details: darker
foreground: "#37dcf6"
terminal_colors:
  bright:
    black: "#1b5689"
    blue: "#4badff"
    cyan: "#37dcf6"
    green: "#7adc03"
    magenta: "#b1a7ff"
    red: "#ff047d"
    white: "#ebe5f2"
    yellow: "#ffeb00"
  normal:
    black: "#1b5689"
    blue: "#4badff"
    cyan: "#37dcf6"
    green: "#7adc03"
    magenta: "#b1a7ff"
    red: "#ff047d"
    white: "#ebe5f2"
    yellow: "#ffeb00"

To Reproduce

Set background image

Expected behaviour

Set background image

Screenshots

Skjermbilde 2023-01-05 kl  09 46 22

Operating System

None

OS Version

13.1

Shell Version

zsh 5.8.1 (arm-apple-darwin21.3.0)

Warp Version

v0.2022.12.13.08.04.stable_01

Additional context

No response

Does this block you from using Warp daily?

Yes, this issue prevents me from using Warp daily.

Warp Internal (ignore): linear-label:b8107fdf-ba31-488d-b103-d271c89cac3e

None

alokedesai commented 1 year ago

Hey @ScopeSV! Sorry for the troubles here. Just to confirm, ~/.warp/themes/standard/30012.jpg is a valid image in that path, right? Out of curiosity, does this work if you use a relative path instead? See this theme as an example.

ScopeSV commented 1 year ago

Yeah I'm 100% sure. And warp terminal even suggested it, so the path works. I tried to do it exactly as the example, but this invalidated the theme I think. Or at least, it got removed from the list of themes. I also tried to set the exact path, by having the image in the same directory and just doing path: 30012.jpg. It didn't work either.

alokedesai commented 1 year ago

Would you be able to zip your ~/.warp/themes directory and send it to me at aloke@warp.dev so I can try to reproduce further? Thank you so much!

alokedesai commented 1 year ago

I see the issue in the zip you sent--the relative path has to be relative to the parent ~/.warp/themes directory, which means that it must be the following. Changing this worked for me.

accent: "#ff047d"
background: "#231b4d"
background_image:
  path: standard/30012.jpg
details: darker
foreground: "#37dcf6"
terminal_colors:
  bright:
    black: "#1b5689"
    blue: "#4badff"
    cyan: "#37dcf6"
    green: "#7adc03"
    magenta: "#b1a7ff"
    red: "#ff047d"
    white: "#ebe5f2"
    yellow: "#ffeb00"
  normal:
    black: "#1b5689"
    blue: "#4badff"
    cyan: "#37dcf6"
    green: "#7adc03"
    magenta: "#b1a7ff"
    red: "#ff047d"
    white: "#ebe5f2"
    yellow: "#ffeb00"

That being said, there does seem to be a bug with absolute paths when using ~. I'll work on fixing this now, with the hope that it's available in next week's release.

dannyneira commented 1 year ago

Thanks for letting us know @ScopeSV, as Aloke mentioned the background path is relative to the ~/.warp/themes folder. We'll post any updates here once the fix is released!

ScopeSV commented 1 year ago

Thanks, that worked. I have an epic look on my iterm, so this will make warp much closer. Your terminal seems good. Can't wait to test it more. Thanks for the update

alokedesai commented 1 year ago

Just an update: I merged a fix yesterday that correctly expands tilde for background images--it should be released in next week's release (going out next Thursday)

outwittester commented 1 month ago

relative path, change from warp.jpg to ./warp.jpg fix the issue