warpdotdev / Warp

Warp is a modern, Rust-based terminal with AI built in so you and your team can build great software, faster.
https://warp.dev
Other
21.55k stars 379 forks source link

More granular and extensive theming support #2441

Open nvlang opened 1 year ago

nvlang commented 1 year ago

Discord username (optional)

No response

Describe the solution you'd like?

More granular and extensive theming support: see additional context.

Is your feature request related to a problem? Please describe.

Much of the UI appearance is controlled by just two color variables, `accent` and `foreground`.

Additional context

Default warp dark theme except with foreground: #ff0000 instead of foreground: #ffffff to illustrate current coarse theming granularity.

Screenshot - Warp feature request - 2023-01-05

How important is this feature to you?

4

Warp Internal (ignore) - linear-label:770f6576-d6c0-4e4f-a259-fc64b5156087

None

dannyneira commented 1 year ago

A ton of great ideas for customization in here, thanks for submitting!

Please :+1: and subscribe to this request as it helps us gauge interest. We will post any updates here.

matthillmanbt commented 1 year ago

Like this idea, was coming to see if something like this was already a request. I would love to be able to set the default foreground text color separately from the general accent coloring of the window, and this would allow that :)

plastikfan commented 1 week ago

This issue seems like a good idea. I was going to submit an a new issue to adress a problem I have found, but it seems like it should be covered by this more generic issue.

I am in the process of migrating away from Warp to Wave and for the most part, this is going ok. I have ported over a Warp theme to work in Wave but it works except for a small but quite important point and that is with the foreground text colour.

In Warp, the foreground text colour is calculated dynamically based upon the user setting such that is actually takes account of the background colour and switching to a high contrast foreground to ease legibility. But this doesnt happen in Wave, which makes the text less readable:

Warp:

Screenshot 2024-11-26 at 13 32 21

Wave:

Screenshot 2024-11-26 at 13 34 51

Just focus on the text in the prompt and you will see what I mean; the prompt text colour changes dynamically based upon the background colour it is being overlayed on, whereas in Wave, the text colour is fixed and therfore difficult to read.