warpdotdev / Warp

Warp is a modern, Rust-based terminal with AI built in so you and your team can build great software, faster.
https://warp.dev
Other
21.07k stars 360 forks source link

Expand on "Some settings from Starship" #2612

Open jvanderen1 opened 1 year ago

jvanderen1 commented 1 year ago

Discord username (optional)

No response

Describe the bug

I am trying to set up my shell to be as Warp-friendly as possible. However, I notice some of the icons look a bit small for me, but doesn't happen in iTerm2:

Screenshot 2023-02-05 at 1 01 51 AM

I found the Some settings from Starship section in the documentation, but there's no context or reasoning added to the suggested setting. In fact, I tried creating a Starship configuration file for the first time, but hit an error:

[WARN] - (starship::config): Failed to load config value: invalid type: boolean `true`, expected struct CustomConfig

Please update documentation to be more clear.

To Reproduce

https://docs.warp.dev/help/known-issues#some-settings-from-starship

Expected behaviour

No response

Screenshots

No response

Operating System

MacOS

OS Version

No response

Shell Version

fish, version 3.6.0

Warp Version

No response

Additional context

No response

Does this block you from using Warp daily?

No

Warp Internal (ignore): linear-label:b8107fdf-ba31-488d-b103-d271c89cac3e

None

dannyneira commented 1 year ago

Hi @jvanderen1 Thanks for submitting, if I understand you correctly, you found the setting in our known issues doc and applied it to your starship and it didn't work? afaik, those settings shouldn't be in Starship for it to work with Warp, but if that isn't the case we can update the docs to reflect this.

jvanderen1 commented 1 year ago

@dannyneira Correct! I was following the known issues doc trying to fix my icon issues. But it seems to be causing other issues.

dannyneira commented 1 year ago

Gotcha, I've noticed emojis render better than icons. Try swapping to using emojis and starship will translate to the icon.

Also for the starship error, comment out or delete the disabled=true & '' = 'https://starship.rs/config-schema.json' lines in your~/.config/starship.toml`

# Get editor completions based on the config schema
#'' = 'https://starship.rs/config-schema.json'

[custom]
#disable=true

CleanShot 2023-02-07 at 09 50 07

jvanderen1 commented 1 year ago

I've tried to change the font to 3 different fonts ("Hack (default)", "FiraCode Nerd Font Mono", "Hack Nerd Font Mono") and it still results in the same small icons. I'm not sure how to change this behavior.

Screenshot 2023-02-09 at 10 21 20 PM
injust commented 2 months ago

Also for the starship error, comment out or delete the disabled=true & '' = 'https://starship.rs/config-schema.json' lines in your~/.config/starship.toml`

# Get editor completions based on the config schema
#'' = 'https://starship.rs/config-schema.json'

[custom]
#disable=true

@dannyneira Sorry to necro an old issue, but this was the only relevant discussion about https://docs.warp.dev/appearance/prompt#starship-settings.


  1. Are there more details on the known errors that are caused by these lines in starship.toml?
    
    # Get editor completions based on the config schema
    '' = 'https://starship.rs/config-schema.json'

Disables the custom module

[custom] disabled = false


I ask because it seems like the config schema does what it says: it allows your editor to provide completions. It doesn't actually change the behaviour of Starship, so I don't understand what problems it could cause with Warp.

---

2. It seems like the first part is outdated. From https://starship.rs/config/#configuration, it should be:

```toml
# Get editor completions based on the config schema
"$schema" = 'https://starship.rs/config-schema.json'