search

warpdotdev / Warp

Warp is a modern, Rust-based terminal with AI built in so you and your team can build great software, faster.
https://warp.dev
Other
21.11k stars 361 forks source link

Polish in UI/Window Layout #267

Open DavidMChan opened 2 years ago

DavidMChan commented 2 years ago

Describe the bug

There are a few (very) minor visual complaints I have with the prompt, which may be UI choices, but I think could look better (or could add polish to the UI of the app):

1) The close/minimize/maximize dots are not aligned vertically with the text tabs, and the top/left is not equal to the padding on the bottom/right. 2) The context hamburger menu in the top right could be a bit smaller vertically, since it looks a bit cramped in relation to the padding on the right of the box. 3) The highlights in the context menu hamburger do not fade out (like the context menu itself), making it look like there are 2-3 extra pixels of width in the highlight.

To Reproduce

Visual bugs, to reproduce just open warp.

Expected behaviour

1) Close/Minimize/Maximize icons could be vertically centered WRT their space. 2) Hamburger menu could be smaller, or better padded. 3) Highlight edges could match with context menu edges.

Screenshots

Issue 1: image

Chrome's close icons (for reference): image

Issue 2: image

Chrome's hamburger menu (for reference): image

Issue 3: image

Issue 3 (Zoomed in): image You can see the one-pixel alpha-channel difference in the above photo.

Operating System

MacOS

OS Version

11.5.2

Additional context

This might also be a feature request? But I figured that since they already exist in the app, it might be better to submit this as a bug report.

DavidMChan commented 2 years ago

Also, just realized issue 1 is a duplicate of #99

zheng commented 2 years ago

Thanks for the detailed feedback! Agree with all 3

elviskahoro commented 2 years ago

Linking:

DavidMChan commented 2 years ago

Just a quick note, while the first part of this issue is a duplicate of #99 - there are also two additional recommendations which are not mentioned in 99.

elviskahoro commented 2 years ago

Thanks @DavidMChan I check across all the duplicates before closing so we can have follow up tasks internally.

mchccc commented 2 years ago

As I clicked on "send feedback" to get to this page, I noticed that the hamburger menu stayed open behind my browser window, and I believe that closing a menu on click should also be a part of UI polish.

elviskahoro commented 2 years ago

@cicuz noted!

warpdotdev-devx commented 2 years ago

The padding in alt grid is fixed via: