search

warpdotdev / Warp

Warp is a modern, Rust-based terminal with AI built in so you and your team can build great software, faster.
https://warp.dev
Other
20.37k stars 337 forks source link

zsh-syntax-highlightning integration - color customization for syntax highlighting #2697

Open ccrvlh opened 1 year ago

ccrvlh commented 1 year ago

Discord username (optional)

No response

Describe the solution you'd like?

This is a continuation of issue #1211 for tracking purposes.
In my current setup (iTerm2 + oh-my-zsh + zsh-syntax-highlightning) I normally customize the highlight for commands to be yellow, bold (`ZSH_HIGHLIGHT_STYLES[arg0]='fg=yellow,bold'`), I personally like this since it helps me clearly differentiate a command from args (and from wrong commands) in a visual way.

Warp does offer a very similar approach, but without customization options, and the syntax-highlightning ends up inconsistent - past commands use `zsh-syntax-highlightning` but current commands use Warp's own highlightning logic - which has a lot of merit, but it currently doesn't offer the same level of customization.

As @Advait-M mentioned it may be challenging to integrate with existing highlighning plugins, but I don't really think this is the pain point - I don't necessarily need `zsh-syntax-highlightning`, so perhaps "only" allowing for color/formatting customization would work perfectly.

Is your feature request related to a problem? Please describe.

No response

Additional context

Although this may seem like an unimportant feature at first, I personally feel this is very important, and one of the reasons I keep going back to iTerm + plugins to get my familiar (and productive) experience.

How important is this feature to you?

3

Warp Internal (ignore) - linear-label:770f6576-d6c0-4e4f-a259-fc64b5156087

None

dannyneira commented 1 year ago

Thanks for submitting @lowercase00. Just referencing the source comment/issue here

Advait-M commented 1 year ago

Thanks for opening an issue @lowercase00 - yep, I think the approach we'll end up taking will be introducing color/formatting customization . And yep - thanks for noting the inconsistency between past commands and current commands, we're also hoping that'll help address this.

Definitely on the list of features we want to add, though, can't give estimates on when we'll get to implementing this!

If other folks run into the same issue, please 👍 the original post above to help us prioritize!

Going to rename the issue to note color customization!