warpdotdev / Warp

Warp is a modern, Rust-based terminal with AI built in so you and your team can build great software, faster.
https://warp.dev
Other
20.77k stars 348 forks source link

Error highlighting in emacs not working #2832

Closed tapegram closed 1 year ago

tapegram commented 1 year ago

Discord username (optional)

No response

Describe the bug

I'm trying to use emacs (spacemacs, more specifically) in warp. The biggest issue I have is that lsp/flycheck syntax highlighting appears not to render.

In Warp

Screenshot 2023-03-24 at 9 47 34 AM

iTerm2

Screenshot 2023-03-24 at 9 49 08 AM

I know it's a pretty minor difference, but that tiny underscore being rendered is pretty critical to me.

A more obivous example with a big typo

Warp:

Screenshot 2023-03-24 at 9 57 39 AM

iterm2

Screenshot 2023-03-24 at 9 58 09 AM

Also if this is just a configuration issue on my end in warp that would be great!

To Reproduce

1) Install spacemacs https://www.spacemacs.org/ 2) Add some language layer (I'm using kotlin with lsp, but I would assume this applies to any syntax checking) 3) Introduce a syntax error and see that the underlining/error highlighting isn't appearing

Note that some themes appear to change the color of the bad syntax, which is good, but it seems like its the minority of themes -- and they still don't underline which is the main indication I am looking for :(

Expected behaviour

No response

Screenshots

No response

Operating System

None

OS Version

13.0.1

Shell Version

zsh 5.8.1 (x86_64-apple-darwin22.0)

Warp Version

v0.2023.03.21.08.02.stable_01

Additional context

No response

Does this block you from using Warp daily?

Yes, this issue prevents me from using Warp daily.

Warp Internal (ignore): linear-label:b8107fdf-ba31-488d-b103-d271c89cac3e

None

dannyneira commented 1 year ago

Hey @tapegram, We appreciate you letting us know, I'll bring this up with the team and if/when we have any updates, we'll post them on this thread.

If anyone else is seeing the same on emacs, please let us know in the comments or with a 👍

acarl005 commented 1 year ago

Hi @tapegram thank you for reporting. This is also affecting my editor. I'm working on a fix for it. Should be fixed soon.

dannyneira commented 1 year ago

Hi all! this has been resolved in the most recent version of Warp. Please update and let us know.

dannyneira commented 1 year ago

Closing as resolved!