warpdotdev / Warp

Warp is a modern, Rust-based terminal with AI built in so you and your team can build great software, faster.
https://warp.dev
Other
21.47k stars 376 forks source link

Setting Font Size Does Not Work? #3030

Open VikR1000 opened 1 year ago

VikR1000 commented 1 year ago

Discord username (optional)

No response

Describe the bug

I've tried to set the terminal font size using the settings dialog and also with warp -s {{16}}, but it hasn't changed.

To Reproduce

Enter warp -s {{16}} in the terminal

Expected behavior

I expect the terminal font size to change to 16pt

Screenshots

Screenshot 2023-05-05 at 11 22 48 PM

Operating System

MacOS

Operating System and Version

13.3.1

Shell Version

GNU bash, version 3.2.57(1) ----- zsh --version zsh 5.9

Warp Version

v0.2023.05.02.08.03.stable_00

Additional context

I'm probably missing something obvious. Warp looks cool!

Does this block you from using Warp daily?

Yes, this issue prevents me from using Warp daily.

Is this a Warp specific issue? (i.e. does it happen in Terminal, iTerm, Kitty, etc.)

Yes, this I confirmed this only happens in Warp, not other terminals.

Warp Internal (ignore): linear-label:b8107fdf-ba31-488d-b103-d271c89cac3e

None

zachgibson commented 1 year ago

Same here. Version v0.2023.05.02.08.03.stable_00

dannyneira commented 1 year ago

Hi @VikR1000 and @zachgibson Thanks for submitting, there isn't a warp cli tool at the moment you could use to change the font. The current way to do this would be thru the Settings > Appearance > Text menus.

CleanShot 2023-05-08 at 11 07 34

Closing this as there is currently no warp cli tool to modify text so this isn't a bug.

zachgibson commented 1 year ago

Sorry @dannyneira I should've clarified what my flow was. Like @VikR1000 mentions:

I've tried to set the terminal font size using the settings dialog and also…

The settings allows me to change the value but it doesn't persist. Restarting the terminal doesn't fix it either.

dannyneira commented 1 year ago

Sorry about that, reopening.

What result do you see when you run defaults read dev.warp.Warp-Stable | grep FontSize before the font change, after the font change, and after restarting Warp?

Also, is this a regression (used to work in a previous Warp version)? If so, what was the last version this worked in?

VikR1000 commented 1 year ago

I found out I could change the font size from the View menu. I changed it to 16pt.

After restarting Warp and before font size change:

defaults read dev.warp.Warp-Stable | grep FontSize
    FontSize = "16.0";

Changing the font size in Settings->Appearance to 20pt, has no effect.

After the change in Settings->Appearance but before restarting Warp:

defaults read dev.warp.Warp-Stable | grep FontSize
    FontSize = "16.0";

After restarting Warp, the font size is still 16pt, and:

defaults read dev.warp.Warp-Stable | grep FontSize
    FontSize = "16.0";
patelsan commented 1 year ago

Hello, any update on this? Warp > Settings > Appearance > Font Size doesn't have any effect and the size goes back to default of 13.

tadsn3w commented 1 year ago

I am facing the same issue. The settings do not work, only the view menu. I don't know if it is persistent, but I am willing to do it daily.

csells commented 1 year ago

ditto. changing the font size in Warp's settings dialog does nothing. The View menu works.

VikR1000 commented 1 year ago

This app is so great that I’m surprised the developer hasn’t fixed this little font size glitch yet. :-) The font in the AI panel is really too small for a lot of people. It looks like it’s about four points. :-)

munjalpatel commented 1 year ago

Same here. Setting font size from Appearance doesn't work.

skoch commented 1 year ago

Yep, same for me. This is the same after I change the setting via Settings -> Appearance as well as after a restart.

defaults read dev.warp.Warp-Stable | grep FontSize
    FontSize = "13.0";

edit; using View -> Increase/Decrease Font Size does, in fact, set the size appropriately and maintain the chosen size after a restart. Fix, imho, would be to:

  1. not allow the field to be editable from Settings -> Appearance
  2. update that field to respond to changes (just like Line height)
  3. add verbiage that changing here doesn't have any affect and that one needs to change this setting using View -> Increase/Decrease Font Size
defaults read dev.warp.Warp-Stable | grep FontSize
    FontSize = "15.0";
jaybeaton commented 9 months ago

I'm seeing this same issue on Linux (Ubuntu) with v0.2024.02.20.08.01.stable_01.

using View -> Increase/Decrease Font Size does, in fact, set the size appropriately and maintain the chosen size after a restart.

I don't see a "View" menu anywhere, but hitting Ctrl+ does increase the font size. That change persists after a restart.

pauljfx commented 1 day ago

Still seeing this issue in 2024

I change the font size in Settings > Appearance > Text > Font Size - it saves the value until I close the app, but does not actually change the font size.

After the app restart - the value resets back to 13.