warpdotdev / Warp

Warp is a modern, Rust-based terminal with AI built in so you and your team can build great software, faster.
https://warp.dev
Other
21.22k stars 366 forks source link

Tab key behavior is broken #3251

Closed yaneshtyagi closed 1 year ago

yaneshtyagi commented 1 year ago

Discord username (optional)

No response

Describe the bug

Partially typing the folder name and pressing tab key is supposed to open auto-complete dropdown. However, with the latest update (v0.2023.06.20.08.04.stable_03) tab key just inserts few spaces at the cursor point. For example if I have a folder engine-core and engine-hood, earlier I could just type eng and hit tab to open auto-complete. Now it just adds spaces e.g. cd eng <tab>.

To reproduce

  1. Open warp terminal
  2. type cd and then partially type any folder name. Hit tab key. Make sure that the file or folder name has more than one similar folders. For example, if you have two folders with name engine-core and engine-hood then type eng and hit tab key.
  3. Spaces are inserted instead of opening auto-complete dropdown.

Expected behavior

No response

Screenshots

No response

Operating system

MacOS

Operating system and version

13.4.1

Shell Version

zsh 5.9 (x86_64-apple-darwin22.0)

Current Warp version

v0.2023.06.20.08.04.stable_03

Regression

Yes, this bug started recently or with an X Warp version

Recent working Warp date

No response

Additional context

No response

Does this block you from using Warp daily?

No

Is this a Warp specific issue? (i.e. does it happen in Terminal, iTerm, Kitty, etc.)

Yes, this I confirmed this only happens in Warp, not other terminals.

Warp Internal (ignore): linear-label:b8107fdf-ba31-488d-b103-d271c89cac3e

None

CalebDu commented 1 year ago

i have same problem

thomasburguiere commented 1 year ago

same issue

JamieMcMillan commented 1 year ago

I have the same issue.

dannyneira commented 1 year ago

Hey Folks, Thanks for letting us know, just to confirm, if you go do Settings > Keyboard Shortcuts, what do you see by "Open Completions menu"? It should be set to TAB by default.

CleanShot 2023-06-26 at 10 49 24

Also, if the TAB key is highlighted, that typically means there is another key bind using the same shortcut, so you can search for TAB in the keyboard shortcuts search to find the conflict. You can also reset the keyboard shortcuts to default to remove the conflict.

yaneshtyagi commented 1 year ago

It's tab.

image
yaneshtyagi commented 1 year ago

No other command is bind to tab. There is one Tab. Would it cause the conflict?

image

But strangely enough, it began working now.

image
yaneshtyagi commented 1 year ago

@CalebDu @thomasburguiere @JamieMcMillan Did it began working for you? I guess that opening the keyboard shortcuts screen and closing it resolved the issue.

cristianblar commented 1 year ago

@CalebDu @thomasburguiere @JamieMcMillan Did it began working for you? I guess that opening the keyboard shortcuts screen and closing it resolved the issue.

It solves the issue temporarily... If you open a new tab or something, it's broken again.

cristianblar commented 1 year ago

Same issue, it's really annoying 😕 auto-completion is the most used feature (at least by me).

JamieMcMillan commented 1 year ago

My keyboard shortcuts are the same as @yaneshtyagi.

wraith1385 commented 1 year ago

I am having the same issue. It's very intermittent

AriJing commented 1 year ago

The same problem! macOS :13.4.1 zsh 5.9 (x86_64-apple-darwin22.0) Warp:v0.2023.06.20.08.04.stable_03

iShot_2023-06-28_11 11 22

Dx-wmc commented 1 year ago

The same problem! macOS :13.4.1 zsh 5.9 (x86_64-apple-darwin22.0) Warp:v0.2023.06.20.08.04.stable_03

iShot_2023-06-28_11 11 22

The same problem!

dannyneira commented 1 year ago

Anyone using bindkey in the rc files by any chance? I;ve noticed it effects TAB completion behaviour. https://docs.warp.dev/help/known-issues#list-of-incompatible-tools

Also, try enabling "Completions as you type" https://docs.warp.dev/features/completions#how-to-access-it to see if that helps.

TheFern2 commented 1 year ago

For me tab seems to be broken when I ssh into a device but works fine locally.

cristianblar commented 1 year ago

The issue is solved now with the last update (v0.2023.06.27.19.34.stable_01).

yaneshtyagi commented 1 year ago

I confirm that the issue is resolved with the v0.2023.06.27.19.34.stable_01 update.

Shall I close the issue?

dannyneira commented 1 year ago

Thanks for confirming all! Closing as resolved, but please feel free to let us know if the issue persists.

TheFern2 commented 1 year ago

@dannyneira Still a little flaky for me. I'm an embedded engineer and I ssh into devices quite often. Even after the update I noticed losing the ability to tab and then it would work later on. Maybe there's a timeout for ssh connections or something. I'll keep an eye when I come back from vacations.

Bit0r commented 7 months ago

Same issue!

KUbuntu 22.04 fish, version 3.7.0 warp, v0.2024.02.20.08.01.stable_02 Input method framework: fcitx5 Input method: rime

When I first changed the tab key behavior, it took effect, but after I closed warp and reopened it, I could only accept autocomplete suggestions with Enter again.

image image

https://github.com/warpdotdev/Warp/assets/43108543/d8ce2848-91cf-4ca1-8705-94ea195f16cf